2022-08-08 20:45:31

by Martin Kaiser

Subject: [PATCH 0/5] staging: r8188eu: clean up _InitQueueReservedPage

Simplify the _InitQueueReservedPage function. Remove unused code.

This series depends on the "simplify endpoint configuration" series.

Martin Kaiser (5):
staging: r8188eu: remove a temporary variable
staging: r8188eu: make numNQ a u8
staging: r8188eu: change all num...Q variables to u8
staging: r8188eu: remove two unused defines
staging: r8188eu: the high prio queue is always selected

drivers/staging/r8188eu/hal/usb_halinit.c | 33 +++++++------------
.../staging/r8188eu/include/rtl8188e_hal.h | 3 +-
.../staging/r8188eu/include/rtl8188e_spec.h | 12 ++-----
3 files changed, 16 insertions(+), 32 deletions(-)

--
2.30.2

2022-08-08 20:48:43

by Martin Kaiser

Subject: [PATCH 1/5] staging: r8188eu: remove a temporary variable

Use pregistrypriv->wifi_spec directly instead of defining a temporary
variable.

Signed-off-by: Martin Kaiser <[email protected]>
---
drivers/staging/r8188eu/hal/usb_halinit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index e1d56370a471..b63f5bb21017 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -160,9 +160,8 @@ static void _InitQueueReservedPage(struct adapter *Adapter)
u32 numPubQ;
u32 value32;
u8 value8;
- bool bWiFiConfig = pregistrypriv->wifi_spec;

- if (bWiFiConfig) {
+ if (pregistrypriv->wifi_spec) {
if (haldata->OutEpQueueSel & TX_SELE_HQ)
numHQ = 0x29;

--
2.30.2

2022-08-08 22:27:51

by Philipp Hortmann

Subject: Re: [PATCH 0/5] staging: r8188eu: clean up _InitQueueReservedPage

On 8/8/22 22:14, Martin Kaiser wrote:
> Simplify the _InitQueueReservedPage function. Remove unused code.
>
> This series depends on the "simplify endpoint configuration" series.
>
> Martin Kaiser (5):
> staging: r8188eu: remove a temporary variable
> staging: r8188eu: make numNQ a u8
> staging: r8188eu: change all num...Q variables to u8
> staging: r8188eu: remove two unused defines
> staging: r8188eu: the high prio queue is always selected
>
> drivers/staging/r8188eu/hal/usb_halinit.c | 33 +++++++------------
> .../staging/r8188eu/include/rtl8188e_hal.h | 3 +-
> .../staging/r8188eu/include/rtl8188e_spec.h | 12 ++-----
> 3 files changed, 16 insertions(+), 32 deletions(-)
>

Tested-by: Philipp Hortmann <[email protected]> # Edimax N150