2022-08-19 09:11:45

by Yang Yingliang

Subject: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()

Add missing pci_disable_device() in error path in chipsfb_pci_init().

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/video/fbdev/chipsfb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
index 393894af26f8..2b00a9d554fc 100644
--- a/drivers/video/fbdev/chipsfb.c
+++ b/drivers/video/fbdev/chipsfb.c
@@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
err_release_fb:
framebuffer_release(p);
err_disable:
+ pci_disable_device(dp);
err_out:
return rc;
}
--
2.25.1

2022-08-22 20:48:48

by Helge Deller

Subject: Re: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()

On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <[email protected]>

applied.
Thanks!
Helge

> ---
> drivers/video/fbdev/chipsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> err_release_fb:
> framebuffer_release(p);
> err_disable:
> + pci_disable_device(dp);
> err_out:
> return rc;
> }