2022-08-20 11:34:12

by Yue Haibing

Subject: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF

WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
Selected by [m]:
- QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]

PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.

Fixes: 7d0221fb5912 ("soc/qcom: Make QCOM_RPMPD select PM_GENERIC_DOMAINS/_OF")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/soc/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index e0d7a5459562..024e420f1bb7 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -129,7 +129,7 @@ config QCOM_RPMHPD

config QCOM_RPMPD
tristate "Qualcomm RPM Power domain driver"
- depends on PM
+ depends on PM && OF
depends on QCOM_SMD_RPM
select PM_GENERIC_DOMAINS
select PM_GENERIC_DOMAINS_OF
--
2.17.1

2022-08-23 01:53:53

by Randy Dunlap

Subject: Re: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF

On 8/20/22 04:32, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
> Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
> Selected by [m]:
> - QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
>
> PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
>
> Fixes: 7d0221fb5912 ("soc/qcom: Make QCOM_RPMPD select PM_GENERIC_DOMAINS/_OF")
> Signed-off-by: YueHaibing <[email protected]>

Works for me. Thanks.

Acked-by: Randy Dunlap <[email protected]> # build-tested

> ---
> drivers/soc/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e0d7a5459562..024e420f1bb7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -129,7 +129,7 @@ config QCOM_RPMHPD
>
> config QCOM_RPMPD
> tristate "Qualcomm RPM Power domain driver"
> - depends on PM
> + depends on PM && OF
> depends on QCOM_SMD_RPM
> select PM_GENERIC_DOMAINS
> select PM_GENERIC_DOMAINS_OF

--
~Randy

2022-08-30 00:21:14

by Bjorn Andersson

Subject: Re: [PATCH -next] soc: qcom: Make QCOM_RPMPD depend on OF

On Sat, 20 Aug 2022 19:32:02 +0800, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS_OF
> Depends on [n]: PM_GENERIC_DOMAINS [=y] && OF [=n]
> Selected by [m]:
> - QCOM_RPMPD [=m] && PM [=y] && QCOM_SMD_RPM [=m]
>
> PM_GENERIC_DOMAINS_OF depends on OF, so QCOM_RPMPD also depends on it.
>
> [...]

Applied, thanks!

[1/1] soc: qcom: Make QCOM_RPMPD depend on OF
commit: 0e5732e4d58437feded42fb459384904eb317e91

Best regards,
--
Bjorn Andersson <[email protected]>