2022-08-20 13:44:34

by Christian Kohlschütter

Subject: [PATCH] regulator: core: Remove "ramp_delay not set" debug message

This message shows up occasionally but in bursts (seen as up 30 times
per second on my ODROID N2+).

According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been
removed after restructuring previous code that assumed that ramp_delay
being zero in that function was an error.

Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
Signed-off-by: Christian Kohlschütter <[email protected]>
---
drivers/regulator/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a5033c6ba01..18fa9206ec2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
(new_uV < old_uV))
return rdev->constraints->settling_time_down;

- if (ramp_delay == 0) {
- rdev_dbg(rdev, "ramp_delay not set\n");
+ if (ramp_delay == 0)
return 0;
- }

return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
}
--
2.36.2

2022-08-20 13:46:03

by Christian Kohlschütter

Subject: [PATCH v2] regulator: core: Remove "ramp_delay not set" debug message

This message shows up occasionally but in bursts (seen up to 30 times
per second on my ODROID N2+).

According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been
removed after restructuring previous code that assumed that ramp_delay
being zero in that function was an error.

Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
Signed-off-by: Christian Kohlschütter <[email protected]>
---
drivers/regulator/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a5033c6ba01..18fa9206ec2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
(new_uV < old_uV))
return rdev->constraints->settling_time_down;

- if (ramp_delay == 0) {
- rdev_dbg(rdev, "ramp_delay not set\n");
+ if (ramp_delay == 0)
return 0;
- }

return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
}
--
2.36.2

2022-08-22 15:48:44

by Matthias Kaehlcke

Subject: Re: [PATCH] regulator: core: Remove "ramp_delay not set" debug message

On Sat, Aug 20, 2022 at 12:24:54PM +0000, Christian Kohlschütter wrote:
> This message shows up occasionally but in bursts (seen as up 30 times
> per second on my ODROID N2+).
>
> According to Matthias Kaehlcke's comment in 'regulator: core: silence
> warning: "VDD1: ramp_delay not set"', this message should have been
> removed after restructuring previous code that assumed that ramp_delay
> being zero in that function was an error.
>
> Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
> Signed-off-by: Christian Kohlschütter <[email protected]>

Reviewed-by: Matthias Kaehlcke <[email protected]>