2022-08-21 14:49:14

by Jisheng Zhang

Subject: [PATCH] riscv: compat: s/failed/unsupported if compat mode isn't supported

When compat mode isn't supported(I believe this is the most case now),
kernel will emit somthing as:
[ 0.050407] riscv: ELF compat mode failed

This msg may make users think there's something wrong with the kernel
itself, replace "failed" with "unsupported" to make it clear. In fact
this is the real compat_mode_supported meaning. After the patch, the
msg would be:
[ 0.050407] riscv: ELF compat mode unsupported

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/riscv/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
index ceb9ebab6558..b0c63e8e867e 100644
--- a/arch/riscv/kernel/process.c
+++ b/arch/riscv/kernel/process.c
@@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)
csr_write(CSR_STATUS, tmp);

pr_info("riscv: ELF compat mode %s",
- compat_mode_supported ? "supported" : "failed");
+ compat_mode_supported ? "supported" : "unsupported");

return 0;
}
--
2.34.1

2022-08-21 14:56:58

by Guo Ren

Subject: Re: [PATCH] riscv: compat: s/failed/unsupported if compat mode isn't supported

On Sun, Aug 21, 2022 at 10:27 PM Jisheng Zhang <[email protected]> wrote:
>
> When compat mode isn't supported(I believe this is the most case now),
> kernel will emit somthing as:
> [ 0.050407] riscv: ELF compat mode failed
>
> This msg may make users think there's something wrong with the kernel
> itself, replace "failed" with "unsupported" to make it clear. In fact
Acked-by: Guo Ren <[email protected]>

> this is the real compat_mode_supported meaning. After the patch, the
> msg would be:
> [ 0.050407] riscv: ELF compat mode unsupported
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/riscv/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
> index ceb9ebab6558..b0c63e8e867e 100644
> --- a/arch/riscv/kernel/process.c
> +++ b/arch/riscv/kernel/process.c
> @@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)
> csr_write(CSR_STATUS, tmp);
>
> pr_info("riscv: ELF compat mode %s",
> - compat_mode_supported ? "supported" : "failed");
> + compat_mode_supported ? "supported" : "unsupported");
>
> return 0;
> }
> --
> 2.34.1
>


--
Best Regards
Guo Ren

2022-10-06 02:50:58

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: compat: s/failed/unsupported if compat mode isn't supported

On Sun, 21 Aug 2022 07:18:19 PDT (-0700), [email protected] wrote:
> When compat mode isn't supported(I believe this is the most case now),
> kernel will emit somthing as:
> [ 0.050407] riscv: ELF compat mode failed
>
> This msg may make users think there's something wrong with the kernel
> itself, replace "failed" with "unsupported" to make it clear. In fact
> this is the real compat_mode_supported meaning. After the patch, the
> msg would be:
> [ 0.050407] riscv: ELF compat mode unsupported
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/riscv/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
> index ceb9ebab6558..b0c63e8e867e 100644
> --- a/arch/riscv/kernel/process.c
> +++ b/arch/riscv/kernel/process.c
> @@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)
> csr_write(CSR_STATUS, tmp);
>
> pr_info("riscv: ELF compat mode %s",
> - compat_mode_supported ? "supported" : "failed");
> + compat_mode_supported ? "supported" : "unsupported");
>
> return 0;
> }

Thanks, this is on for-next.