2022-08-22 21:43:11

by Rob Herring (Arm)

Subject: Re: [PATCH v6 02/17] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC

On Sat, Aug 20, 2022 at 12:57:35PM -0700, Brad Larson wrote:
> From: Brad Larson <[email protected]>
>
> AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and
> explicitly controls byte-lane enables.
>
> Signed-off-by: Brad Larson <[email protected]>
> ---
> .../devicetree/bindings/mmc/cdns,sdhci.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index 4207fed62dfe..964b610eeef2 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -17,12 +17,14 @@ properties:
> compatible:
> items:
> - enum:
> + - amd,pensando-elba-sd4hc
> - microchip,mpfs-sd4hc
> - socionext,uniphier-sd4hc
> - const: cdns,sd4hc
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> interrupts:
> maxItems: 1
> @@ -118,6 +120,15 @@ required:
> - interrupts
> - clocks
>
> +if:
> + properties:
> + compatible:
> + const: amd,pensando-elba-sd4hc
> +then:
> + properties:
> + reg:
> + minItems: 2

else:
properties:
reg:
maxItems: 1

> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.17.1
>
>

2022-08-31 22:42:27

by Larson, Bradley

Subject: Re: [PATCH v6 02/17] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC

On 8/22/22 2:29 PM, Rob Herring wrote:
> On Sat, Aug 20, 2022 at 12:57:35PM -0700, Brad Larson wrote:
>> From: Brad Larson <[email protected]>
>>
>> AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and
>> explicitly controls byte-lane enables.
>>
>> Signed-off-by: Brad Larson <[email protected]>
>> ---
>> .../devicetree/bindings/mmc/cdns,sdhci.yaml | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> index 4207fed62dfe..964b610eeef2 100644
>> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> @@ -17,12 +17,14 @@ properties:
>> compatible:
>> items:
>> - enum:
>> + - amd,pensando-elba-sd4hc
>> - microchip,mpfs-sd4hc
>> - socionext,uniphier-sd4hc
>> - const: cdns,sd4hc
>>
>> reg:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>>
>> interrupts:
>> maxItems: 1
>> @@ -118,6 +120,15 @@ required:
>> - interrupts
>> - clocks
>>
>> +if:
>> + properties:
>> + compatible:
>> + const: amd,pensando-elba-sd4hc
>> +then:
>> + properties:
>> + reg:
>> + minItems: 2
> else:
> properties:
> reg:
> maxItems: 1

Added this change.

Regards,
Brad