2022-08-28 06:47:45

by Oleksij Rempel

Subject: [PATCH net-next v4 1/7] dt-bindings: net: phy: add PoDL PSE property

Add property to reference node representing a PoDL Power Sourcing Equipment.

Signed-off-by: Oleksij Rempel <[email protected]>
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index ed1415a4381f2..0b7b9dc69d454 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -144,6 +144,11 @@ properties:
Mark the corresponding energy efficient ethernet mode as
broken and request the ethernet to stop advertising it.

+ ieee802.3-pse:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Specifies a reference to a node representing a Power Sourcing Equipment.
+
phy-is-integrated:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.30.2

2022-08-30 20:37:59

by Rob Herring

Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: phy: add PoDL PSE property

On Sun, Aug 28, 2022 at 08:30:15AM +0200, Oleksij Rempel wrote:
> Add property to reference node representing a PoDL Power Sourcing Equipment.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> index ed1415a4381f2..0b7b9dc69d454 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -144,6 +144,11 @@ properties:
> Mark the corresponding energy efficient ethernet mode as
> broken and request the ethernet to stop advertising it.
>
> + ieee802.3-pse:
> + $ref: /schemas/types.yaml#/definitions/phandle

If you are saying this is the only location we'll ever find
'ieee802.3-pse', then defining it here is okay. Otherwise, it
needs to be it's own file so there's exactly 1 type definition. As
you've said it might have cells by defining #pse-cells, 'phandle' is
the wrong type. 'phandle-array' is what you want, but then actual users
need to define how many entries (i.e. maxItems). Just like all the
other provider/consumer bindings are structured.

Rob