2022-08-29 22:14:44

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings

With 'unevaluatedProperties' support implemented, there's a number of
warnings when running dtbs_check:

arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml

The main problem is that bindings schema marks resets as a required
property for RZ/G2L (and alike) SoC's but resets property is not part
of schema. So to fix this just add a resets property with maxItems
set to 1.

Signed-off-by: Lad Prabhakar <[email protected]>
---
Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index bb1f3c7e0e6a..2291a7cd619b 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -60,6 +60,9 @@ properties:
power-domains:
maxItems: 1

+ resets:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.25.1


2022-08-30 08:04:24

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings

On Mon, Aug 29, 2022 at 11:47 PM Lad Prabhakar
<[email protected]> wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-08-30 09:36:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings

On 30/08/2022 00:47, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-08-30 10:45:44

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings

On Mon, Aug 29, 2022 at 10:47:30PM +0100, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (731.00 B)
signature.asc (849.00 B)
Download all attachments