2022-09-03 23:06:18

by Li Zhong

Subject: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime_get()

clk_pm_runtime_get() could fail. Check the return status.

Signed-off-by: Li Zhong <[email protected]>
---
drivers/clk/clk.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7fc191c15507..09353f7bf052 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2981,8 +2981,12 @@ static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
int level)
{
struct clk_core *child;
+ int ret;
+
+ ret = clk_pm_runtime_get(c);
+ if (ret)
+ return;

- clk_pm_runtime_get(c);
clk_summary_show_one(s, c, level);
clk_pm_runtime_put(c);

--
2.25.1

2022-09-30 00:51:11

by Stephen Boyd

Subject: Re: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime_get()

Quoting Li Zhong (2022-09-03 15:41:25)
> clk_pm_runtime_get() could fail. Check the return status.
>
> Signed-off-by: Li Zhong <[email protected]>
> ---
> drivers/clk/clk.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 7fc191c15507..09353f7bf052 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2981,8 +2981,12 @@ static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
> int level)
> {
> struct clk_core *child;
> + int ret;
> +
> + ret = clk_pm_runtime_get(c);
> + if (ret)
> + return;
>
> - clk_pm_runtime_get(c);

The patch is malformed. It can't be applied, sorry. Also, shouldn't we
print something if we can't runtime PM get?

> clk_summary_show_one(s, c, level);
> clk_pm_runtime_put(c);
>