2022-09-13 10:22:49

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the imx-mxs tree

Hi all,

In commit

c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")

Fixes tag

Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400

has these problem(s):

- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-09-13 18:20:17

by Tim Harvey

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
>
> Fixes tag
>
> Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>

Stephen,

Sorry, that was my fault with my editor's word-wrap getting in the
way. I will be more careful in the future.

Is there anything that I can and should do at this point to result this one?

Best Regards,

Tim

2022-09-14 04:11:51

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Tue, Sep 13, 2022 at 10:08:16AM -0700, Tim Harvey wrote:
> On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> > c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
> >
> > Fixes tag
> >
> > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
> >
> > has these problem(s):
> >
> > - Subject has leading but no trailing parentheses
> > - Subject has leading but no trailing quotes
> >
> > Please do not split Fixes tags over more than one line.
> >
>
> Stephen,
>
> Sorry, that was my fault with my editor's word-wrap getting in the
> way. I will be more careful in the future.
>
> Is there anything that I can and should do at this point to result this one?

I fixed it up.

Shawn

2022-09-14 15:54:06

by Tim Harvey

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Tue, Sep 13, 2022 at 8:48 PM Shawn Guo <[email protected]> wrote:
>
> On Tue, Sep 13, 2022 at 10:08:16AM -0700, Tim Harvey wrote:
> > On Tue, Sep 13, 2022 at 3:16 AM Stephen Rothwell <[email protected]> wrote:
> > >
> > > Hi all,
> > >
> > > In commit
> > >
> > > c1f84a75babe ("arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation")
> > >
> > > Fixes tag
> > >
> > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
> > >
> > > has these problem(s):
> > >
> > > - Subject has leading but no trailing parentheses
> > > - Subject has leading but no trailing quotes
> > >
> > > Please do not split Fixes tags over more than one line.
> > >
> >
> > Stephen,
> >
> > Sorry, that was my fault with my editor's word-wrap getting in the
> > way. I will be more careful in the future.
> >
> > Is there anything that I can and should do at this point to result this one?
>
> I fixed it up.
>
> Shawn

Thanks Shawn!

I guess this would be a nice thing for checkpatch to catch.

Tim