2022-09-14 08:42:30

by Jilin Yuan

[permalink] [raw]
Subject: [PATCH] ARM: pxa: fix repeated words in comments

Delete the redundant word 'in'.

Signed-off-by: Jilin Yuan <[email protected]>
---
arch/arm/mach-pxa/palm27x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
index 1a8d25eecac3..116183859357 100644
--- a/arch/arm/mach-pxa/palm27x.c
+++ b/arch/arm/mach-pxa/palm27x.c
@@ -160,7 +160,7 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode)
#if defined(CONFIG_USB_PXA27X) || \
defined(CONFIG_USB_PXA27X_MODULE)

-/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
+/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
.dev_id = "gpio-vbus",
.table = {
--
2.36.1


2022-09-27 13:51:48

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] ARM: pxa: fix repeated words in comments

On Wed, Sep 14, 2022 at 04:37:46PM +0800, Jilin Yuan wrote:
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
> static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
> .dev_id = "gpio-vbus",
> .table = {

NAK!

The reasons:
* I read the comment above (without the patch) as "The actual offsets get
set in the function call". Both ins are of different parts of speech
(adverbial and preposition).
* As I stated to other developers (see [1] and [2]), you and other
@cdjrlc.com developers ignore critical code reviews (no reply to
them).

Thanks.

[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/lkml/[email protected]/

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (908.00 B)
signature.asc (235.00 B)
Download all attachments