2022-09-14 14:26:10

by Dmitry Torokhov

Subject: [PATCH 3/5] Input: auo-pixcir-ts - do not force rising edge interrupt trigger

Instead of hard-coding rising edge as the interrupt trigger, let's rely on
the platform (ACPI, DT) to configure the interrupt properly.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/touchscreen/auo-pixcir-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
index c3bce9fb2c94..4960a50f59ea 100644
--- a/drivers/input/touchscreen/auo-pixcir-ts.c
+++ b/drivers/input/touchscreen/auo-pixcir-ts.c
@@ -612,7 +612,7 @@ static int auo_pixcir_probe(struct i2c_client *client,

error = devm_request_threaded_irq(&client->dev, client->irq,
NULL, auo_pixcir_interrupt,
- IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ IRQF_ONESHOT,
input_dev->name, ts);
if (error) {
dev_err(&client->dev, "irq %d requested failed, %d\n",
--
2.37.2.789.g6183377224-goog

2022-09-14 15:09:37

by Heiko Stübner

Subject: Re: [PATCH 3/5] Input: auo-pixcir-ts - do not force rising edge interrupt trigger

Am Mittwoch, 14. September 2022, 16:14:26 CEST schrieb Dmitry Torokhov:
> Instead of hard-coding rising edge as the interrupt trigger, let's rely on
> the platform (ACPI, DT) to configure the interrupt properly.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>