2022-09-19 09:26:29

by Lukas Bulwahn

Subject: [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring

Commit 78013eaadf69 ("x86: remove the IOMMU table infrastructure")
refactored the generic swiotlb/swiotlb-xen setup into pci-dma.c, but
misses to adjust MAINTAINERS.

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about
broken references.

Update the SWIOTLB SUBSYSTEM to contain the architecture-independent
pieces for swiotlb, but leave the small architecture-dependent pieces to
the architecture maintainers.

Further, update the XEN SWIOTLB SUBSYSTEM to include all swiotlb-xen
headers and replace the pattern in drivers with the specific one file that
matches this pattern.

Signed-off-by: Lukas Bulwahn <[email protected]>
Acked-by: Juergen Gross <[email protected]>
---
v1: https://lore.kernel.org/lkml/[email protected]/
v1 -> v2:
addressed Christoph's comment, removed arch/*/kernel/pci-swiotlb.c
added Juergen's ack

Christoph, please pick this minor non-urgent clean-up patch for swiotlb.

MAINTAINERS | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index babb441f7474..69d58c43bd6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19699,7 +19699,6 @@ L: [email protected]
S: Supported
W: http://git.infradead.org/users/hch/dma-mapping.git
T: git git://git.infradead.org/users/hch/dma-mapping.git
-F: arch/*/kernel/pci-swiotlb.c
F: include/linux/swiotlb.h
F: kernel/dma/swiotlb.c

@@ -22403,8 +22402,10 @@ M: Stefano Stabellini <[email protected]>
L: [email protected] (moderated for non-subscribers)
L: [email protected]
S: Supported
-F: arch/x86/xen/*swiotlb*
-F: drivers/xen/*swiotlb*
+F: arch/*/include/asm/xen/swiotlb-xen.h
+F: drivers/xen/swiotlb-xen.c
+F: include/xen/arm/swiotlb-xen.h
+F: include/xen/swiotlb-xen.h

XFS FILESYSTEM
C: irc://irc.oftc.net/xfs
--
2.17.1

2022-09-20 07:16:09

by Christoph Hellwig

Subject: Re: [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring

Sorry for coming up with this only now, but what about just dropping
the separate swiotlb entry entirely, and just add include/linux/swiotlb.h
to the dma-mapping entry?

2022-09-22 11:05:39

by Lukas Bulwahn

Subject: Re: [PATCH v2] MAINTAINERS: refurbish SWIOTLB SUBSYSTEM sections after refactoring

On Tue, Sep 20, 2022 at 8:43 AM Christoph Hellwig <[email protected]> wrote:
>
> Sorry for coming up with this only now, but what about just dropping
> the separate swiotlb entry entirely, and just add include/linux/swiotlb.h
> to the dma-mapping entry?

Sure, great idea. I just sent a patch v3 doing so:

https://lore.kernel.org/lkml/[email protected]/

Lukas