2022-09-20 04:43:03

by Dmitry Torokhov

[permalink] [raw]
Subject: [PATCH 2/4] dt-binding: input: egalax-ts: fix GPIO and IRQ in example

The driver is using level triggered interrupt (low) which is backed by
and active low GPIO that can be used to wake the controller by driving it
low. Let's annotate it properly in the example.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
.../devicetree/bindings/input/touchscreen/egalax-ts.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
index 92fb2620f5e2..ebbe93810574 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
@@ -13,6 +13,6 @@ Example:
compatible = "eeti,egalax_ts";
reg = <0x04>;
interrupt-parent = <&gpio1>;
- interrupts = <9 2>;
- wakeup-gpios = <&gpio1 9 0>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+ wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
};
--
2.37.3.968.ga6b4b080e4-goog


2022-09-21 06:53:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/4] dt-binding: input: egalax-ts: fix GPIO and IRQ in example

On 20/09/2022 06:26, Dmitry Torokhov wrote:
> The driver is using level triggered interrupt (low) which is backed by
> and active low GPIO that can be used to wake the controller by driving it
> low. Let's annotate it properly in the example.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof