2022-09-23 02:00:43

by liangxu.xu

[permalink] [raw]
Subject: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188

From: liangxu xu <[email protected]>

Add dt-binding documentation of dpi for MediaTek MT8188 SoC.

Signed-off-by: liangxu xu <[email protected]>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5bb23e97cf33..d976380801e3 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -23,6 +23,7 @@ properties:
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
- mediatek,mt8186-dpi
+ - mediatek,mt8188-dp-intf
- mediatek,mt8192-dpi
- mediatek,mt8195-dp-intf

--
2.25.1


2022-09-23 11:25:01

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188

On 23/09/2022 03:42, [email protected] wrote:
> From: liangxu xu <[email protected]>
>
> Add dt-binding documentation of dpi for MediaTek MT8188 SoC.
>
> Signed-off-by: liangxu xu <[email protected]>

Where is the DTS? Where are driver changes?

Best regards,
Krzysztof

2022-09-26 15:45:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8188

On 26/09/2022 14:12, liangxu.xu wrote:
>
> Can I modify it to the following form:
> properties:
> compatible:
> oneOf:
> - enum:
> - mediatek,mt2701-dpi
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
> - mediatek,mt8195-dp-intf
> - items:
> - enum:
> - mediatek,mt8188-dp-intf
> - const: mediatek,mt8195-dp-intf
>
> This means that mt8188 reuses mt8195, so there is no need to add
> compatible to the driver.

I am now confused. You send some bindings which do not match DTS and driver?

This has to stop... please post the bindings with the user - DTS and
optionally driver.

Best regards,
Krzysztof