2022-09-23 19:54:42

by Dmitry Torokhov

Subject: [PATCH 1/5] Input: lm8333 - add missing linux/input.h include

We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.

Also let's sort includes alphabetically and drop unneeded irq.h

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/keyboard/lm8333.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 9dac22c14125..3052cd6dedac 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -4,13 +4,13 @@
* Copyright (C) 2012 Wolfram Sang, Pengutronix <[email protected]>
*/

-#include <linux/module.h>
-#include <linux/slab.h>
-#include <linux/irq.h>
#include <linux/i2c.h>
-#include <linux/interrupt.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/input/lm8333.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/slab.h>

#define LM8333_FIFO_READ 0x20
#define LM8333_DEBOUNCE 0x22
--
2.37.3.998.g577e59143f-goog

2022-09-23 19:54:52

by Dmitry Torokhov

Subject: [PATCH 5/5] Input: ep93xx_keypad - add missing linux/input.h include

We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/keyboard/ep93xx_keypad.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index 7a3b0664ab4f..f5bf7524722a 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -23,6 +23,7 @@
#include <linux/interrupt.h>
#include <linux/clk.h>
#include <linux/io.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/slab.h>
#include <linux/soc/cirrus/ep93xx.h>
--
2.37.3.998.g577e59143f-goog

2022-09-23 19:55:00

by Dmitry Torokhov

Subject: [PATCH 3/5] Input: mt6779-keypad - add missing linux/input.h include

We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/keyboard/mt6779-keypad.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
index a05e70af1fd0..19f69d167fbd 100644
--- a/drivers/input/keyboard/mt6779-keypad.c
+++ b/drivers/input/keyboard/mt6779-keypad.c
@@ -5,6 +5,7 @@
*/
#include <linux/bitops.h>
#include <linux/clk.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/interrupt.h>
#include <linux/module.h>
--
2.37.3.998.g577e59143f-goog

2022-09-23 20:07:42

by Dmitry Torokhov

Subject: [PATCH 4/5] Input: imx_keypad - add missing linux/input.h include

We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/keyboard/imx_keypad.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
index ae9303848571..e15a93619e82 100644
--- a/drivers/input/keyboard/imx_keypad.c
+++ b/drivers/input/keyboard/imx_keypad.c
@@ -7,6 +7,7 @@
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/err.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/interrupt.h>
#include <linux/io.h>
--
2.37.3.998.g577e59143f-goog

2022-09-26 13:17:00

by Andy Shevchenko

Subject: Re: [PATCH 1/5] Input: lm8333 - add missing linux/input.h include

On Fri, Sep 23, 2022 at 12:47:34PM -0700, Dmitry Torokhov wrote:
> We are going to clean up matrix_keymap.h from unnecessary includes,
> so the driver needs to include API that it uses directly.
>
> Also let's sort includes alphabetically and drop unneeded irq.h

For the entire series:
Reviewed-by: Andy Shevchenko <[email protected]>

Thanks for doing this!

--
With Best Regards,
Andy Shevchenko