2022-09-25 11:08:41

by Krzysztof Kozlowski

Subject: [PATCH 11/15] dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and gpio-line-names

Document common GPIO properties (gpio-reserved-ranges and
gpio-line-names), already used on qrb5165-rb5 board.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
index c44d02d28bc9..d7d8e5d3b659 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
@@ -49,6 +49,13 @@ properties:
gpio-ranges:
maxItems: 1

+ gpio-reserved-ranges:
+ minItems: 1
+ maxItems: 90
+
+ gpio-line-names:
+ maxItems: 180
+
wakeup-parent: true

#PIN CONFIGURATION NODES
--
2.34.1

2022-09-27 14:00:30

by Krzysztof Kozlowski

Subject: Re: [PATCH 11/15] dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and gpio-line-names

On 27/09/2022 14:41, Konrad Dybcio wrote:
>
>
> On 25.09.2022 13:06, Krzysztof Kozlowski wrote:
>> Document common GPIO properties (gpio-reserved-ranges and
>> gpio-line-names), already used on qrb5165-rb5 board.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
>> index c44d02d28bc9..d7d8e5d3b659 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
>> @@ -49,6 +49,13 @@ properties:
>> gpio-ranges:
>> maxItems: 1
>>
>> + gpio-reserved-ranges:
>> + minItems: 1
> Not sure about this.. However, this will apply to 99.9% of boards, so:

We need some minimum number.

Best regards,
Krzysztof

2022-09-27 14:20:26

by Konrad Dybcio

Subject: Re: [PATCH 11/15] dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and gpio-line-names

On 25.09.2022 13:06, Krzysztof Kozlowski wrote:
> Document common GPIO properties (gpio-reserved-ranges and
> gpio-line-names), already used on qrb5165-rb5 board.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> index c44d02d28bc9..d7d8e5d3b659 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> @@ -49,6 +49,13 @@ properties:
> gpio-ranges:
> maxItems: 1
>
> + gpio-reserved-ranges:
> + minItems: 1
Not sure about this.. However, this will apply to 99.9% of boards, so:

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> + maxItems: 90
> +
> + gpio-line-names:
> + maxItems: 180
> +
> wakeup-parent: true
>
> #PIN CONFIGURATION NODES

2022-09-29 20:21:43

by Rob Herring

Subject: Re: [PATCH 11/15] dt-bindings: pinctrl: qcom,sm8250: add gpio-reserved-ranges and gpio-line-names

On Sun, 25 Sep 2022 13:06:04 +0200, Krzysztof Kozlowski wrote:
> Document common GPIO properties (gpio-reserved-ranges and
> gpio-line-names), already used on qrb5165-rb5 board.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Acked-by: Rob Herring <[email protected]>