2022-09-26 08:19:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings

Hi,

Changes since v1
================
v1: https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
1. As Stephan suggested, move check for function on non-GPIO pins to common
TLMM schema. This affects few commits in the set named:
"use common TLMM schema"
"do not require function on non-GPIOs"

Overview
========
This is the third, independent patchset around Qualcomm pinctrl in recent days:
1. First round of TLMM fixes: merged
2. LPASS fixes:
https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
3. ARMv7 TLMM fixes: *THIS PATCHSET*
4. ARMv8 remaining TLMM fixes: v1 send:
https://lore.kernel.org/linux-devicetree/[email protected]/T/#t

Dependencies
============
1. No dependencies.
2. dt-bindings are independent of DTS patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (33):
arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function
dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux
dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config
dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema
dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example
dt-bindings: pinctrl: qcom,msm8226: fix matching pin config
dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema
dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable
dt-bindings: pinctrl: qcom,msm8226: fix indentation in example
dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config
dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on
non-GPIOs
dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example
dt-bindings: pinctrl: qcom,msm8953: fix matching pin config
dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema
dt-bindings: pinctrl: qcom,msm8953: fix indentation in example
dt-bindings: pinctrl: qcom,mdm9607: do not require function on
non-GPIOs
dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example
dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config
dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema
dt-bindings: pinctrl: qcom,sdx55: fix matching pin config
dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema
dt-bindings: pinctrl: qcom,sdx55: fix indentation in example
dt-bindings: pinctrl: qcom,sdx65: fix matching pin config
dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema
dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example
(remaining piece)

.../pinctrl/qcom,ipq6018-pinctrl.yaml | 60 +++++++++--------
.../pinctrl/qcom,mdm9607-pinctrl.yaml | 23 ++++---
.../pinctrl/qcom,msm8226-pinctrl.yaml | 63 +++++++++---------
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 64 +++++++++----------
.../pinctrl/qcom,msm8953-pinctrl.yaml | 51 ++++++++-------
.../pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++--
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++-
.../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +-
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 51 ++++++++-------
.../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 12 ++--
.../bindings/pinctrl/qcom,tlmm-common.yaml | 20 ++++--
arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +-
arch/arm/boot/dts/qcom-msm8226.dtsi | 24 +++----
.../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++++-----
.../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++--------
arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 ++-
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +-
18 files changed, 264 insertions(+), 227 deletions(-)

--
2.34.1


2022-09-26 08:20:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 07/33] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function

Certain pins, like SDcard related, do not have functions and such should
not be required. Add a check for this in common Qualcomm TLMM pin
controller schema.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,tlmm-common.yaml | 20 +++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index c88c8dcb69d9..e1354f0c64f8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -65,10 +65,6 @@ additionalProperties: true

$defs:
qcom-tlmm-state:
- allOf:
- - $ref: pincfg-node.yaml#
- - $ref: pinmux-node.yaml#
-
properties:
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
@@ -82,5 +78,21 @@ $defs:
output-high: true
output-low: true

+ allOf:
+ - $ref: pincfg-node.yaml#
+ - $ref: pinmux-node.yaml#
+
+ - if:
+ properties:
+ pins:
+ items:
+ pattern: "^gpio"
+ then:
+ required:
+ - function
+ else:
+ properties:
+ function: false
+
additionalProperties: true
...
--
2.34.1

2022-09-26 08:20:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 33/33] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece)

Bindings example should be indented with 4-spaces. Previous adjustment
missefd one spot.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
index b9ab130cd558..0b251caaebf2 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
@@ -139,8 +139,8 @@ examples:
gpio-ranges = <&tlmm 0 0 230>;

gpio-wo-subnode-state {
- pins = "gpio1";
- function = "gpio";
+ pins = "gpio1";
+ function = "gpio";
};

uart-w-subnodes-state {
--
2.34.1

2022-09-26 08:20:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 14/33] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema

Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index ecb90c77f666..4420bb23c9dc 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -60,7 +60,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"

properties:
pins:
@@ -101,12 +101,11 @@ $defs:

required:
- pins
- - function

additionalProperties: false

allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#

required:
- compatible
--
2.34.1

2022-09-26 08:20:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 31/33] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema

Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
index 0f796f1f0104..f5451b1a3a2f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
@@ -142,10 +142,12 @@ patternProperties:

required:
- pins
- - function

additionalProperties: false

+allOf:
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
+
required:
- compatible
- reg
--
2.34.1

2022-09-26 08:20:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 28/33] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema

Reference common Qualcomm TLMM pin controller schema, to bring other
regular schemas and additional checks, like function required only for
GPIOs.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
index fff57abf4fbc..52b7a557f452 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
@@ -60,7 +60,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "/schemas/pinctrl/pincfg-node.yaml"
+ $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"

properties:
pins:
@@ -122,12 +122,11 @@ $defs:

required:
- pins
- - function

additionalProperties: false

allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#

required:
- compatible
--
2.34.1

2022-09-26 08:21:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 24/33] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example

Bindings example should be indented with 4-spaces.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../pinctrl/qcom,mdm9607-pinctrl.yaml | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index 57a4fed55de7..a37b358715a3 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -120,14 +120,14 @@ patternProperties:

examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- tlmm: pinctrl@1000000 {
- compatible = "qcom,mdm9607-tlmm";
- reg = <0x01000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- gpio-ranges = <&msmgpio 0 0 80>;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ tlmm: pinctrl@1000000 {
+ compatible = "qcom,mdm9607-tlmm";
+ reg = <0x01000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ gpio-ranges = <&msmgpio 0 0 80>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
--
2.34.1

2022-09-26 08:22:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 19/33] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example

Bindings example should be indented with 4-spaces.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 60 +++++++++----------
1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
index 08e2dd5cbebe..9c647e24fa9a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
@@ -118,35 +118,35 @@ $defs:

examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
-
- pinctrl@1000000 {
- compatible = "qcom,msm8909-tlmm";
- reg = <0x1000000 0x300000>;
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&tlmm 0 0 117>;
- interrupt-controller;
- #interrupt-cells = <2>;
-
- gpio-wo-subnode-state {
- pins = "gpio1";
- function = "gpio";
- };
-
- uart-w-subnodes-state {
- rx-pins {
- pins = "gpio4";
- function = "blsp_uart1";
- bias-pull-up;
- };
-
- tx-pins {
- pins = "gpio5";
- function = "blsp_uart1";
- bias-disable;
- };
- };
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ pinctrl@1000000 {
+ compatible = "qcom,msm8909-tlmm";
+ reg = <0x1000000 0x300000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 117>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ gpio-wo-subnode-state {
+ pins = "gpio1";
+ function = "gpio";
};
+
+ uart-w-subnodes-state {
+ rx-pins {
+ pins = "gpio4";
+ function = "blsp_uart1";
+ bias-pull-up;
+ };
+
+ tx-pins {
+ pins = "gpio5";
+ function = "blsp_uart1";
+ bias-disable;
+ };
+ };
+ };
...
--
2.34.1

2022-09-26 08:23:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 23/33] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs

Certain pins, like SDcard related, do not have functions and such should
not be required.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index f7bd4be1739e..57a4fed55de7 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -115,7 +115,6 @@ patternProperties:

required:
- pins
- - function

additionalProperties: false

--
2.34.1

2022-09-26 08:24:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 32/33] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config

The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
index ad3496784678..4606ca980dc4 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
@@ -47,9 +47,17 @@ properties:

wakeup-parent: true

-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-sc7280-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-sc7280-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -162,7 +170,7 @@ examples:
gpio-ranges = <&tlmm 0 0 175>;
wakeup-parent = <&pdc>;

- qup_uart5_default: qup-uart5-pins {
+ qup_uart5_default: qup-uart5-state {
pins = "gpio46", "gpio47";
function = "qup13";
drive-strength = <2>;
--
2.34.1

2022-09-26 08:27:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 30/33] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config

The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
index cdfcf29dffee..0f796f1f0104 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
@@ -49,8 +49,10 @@ patternProperties:
oneOf:
- $ref: "#/$defs/qcom-sdx65-tlmm-state"
- patternProperties:
- ".*":
+ "-pins$":
$ref: "#/$defs/qcom-sdx65-tlmm-state"
+ additionalProperties: false
+
'$defs':
qcom-sdx65-tlmm-state:
type: object
@@ -175,13 +177,13 @@ examples:
};

uart-w-subnodes-state {
- rx {
+ rx-pins {
pins = "gpio4";
function = "blsp_uart1";
bias-pull-up;
};

- tx {
+ tx-pins {
pins = "gpio5";
function = "blsp_uart1";
bias-disable;
--
2.34.1

2022-09-26 08:28:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 20/33] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config

The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'. Otherwise the subnodes
(level one and two) are not properly matched. This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
index d4da558cde54..c162796ab604 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
@@ -44,9 +44,17 @@ properties:
gpio-ranges:
maxItems: 1

-#PIN CONFIGURATION NODES
patternProperties:
- '-pins$':
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-msm8953-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-msm8953-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-msm8953-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
@@ -163,7 +171,7 @@ examples:
#gpio-cells = <2>;
gpio-ranges = <&tlmm 0 0 142>;

- serial_default: serial-pins {
+ serial_default: serial-state {
pins = "gpio4", "gpio5";
function = "blsp_uart2";
drive-strength = <2>;
--
2.34.1

2022-09-27 04:03:26

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2 00/33] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings

On Mon, Sep 26, 2022 at 09:43:42AM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes since v1
> ================
> v1: https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> 1. As Stephan suggested, move check for function on non-GPIO pins to common
> TLMM schema. This affects few commits in the set named:
> "use common TLMM schema"
> "do not require function on non-GPIOs"
>
> Overview
> ========
> This is the third, independent patchset around Qualcomm pinctrl in recent days:
> 1. First round of TLMM fixes: merged
> 2. LPASS fixes:
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> 3. ARMv7 TLMM fixes: *THIS PATCHSET*
> 4. ARMv8 remaining TLMM fixes: v1 send:
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
>
> Dependencies
> ============
> 1. No dependencies.
> 2. dt-bindings are independent of DTS patches.
>
> Best regards,
> Krzysztof

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

>
> Krzysztof Kozlowski (33):
> arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins
> arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema
> ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl
> ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema
> ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema
> ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema
> dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
> dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function
> dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux
> dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config
> dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema
> dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8226: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema
> dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable
> dt-bindings: pinctrl: qcom,msm8226: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on
> non-GPIOs
> dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example
> dt-bindings: pinctrl: qcom,msm8953: fix matching pin config
> dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema
> dt-bindings: pinctrl: qcom,msm8953: fix indentation in example
> dt-bindings: pinctrl: qcom,mdm9607: do not require function on
> non-GPIOs
> dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example
> dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config
> dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema
> dt-bindings: pinctrl: qcom,sdx55: fix matching pin config
> dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema
> dt-bindings: pinctrl: qcom,sdx55: fix indentation in example
> dt-bindings: pinctrl: qcom,sdx65: fix matching pin config
> dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema
> dt-bindings: pinctrl: qcom,sc7280: fix matching pin config
> dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example
> (remaining piece)
>
> .../pinctrl/qcom,ipq6018-pinctrl.yaml | 60 +++++++++--------
> .../pinctrl/qcom,mdm9607-pinctrl.yaml | 23 ++++---
> .../pinctrl/qcom,msm8226-pinctrl.yaml | 63 +++++++++---------
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 64 +++++++++----------
> .../pinctrl/qcom,msm8953-pinctrl.yaml | 51 ++++++++-------
> .../pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++--
> .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++-
> .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +-
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 51 ++++++++-------
> .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 12 ++--
> .../bindings/pinctrl/qcom,tlmm-common.yaml | 20 ++++--
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +-
> arch/arm/boot/dts/qcom-msm8226.dtsi | 24 +++----
> .../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++++-----
> .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++--------
> arch/arm/boot/dts/qcom-sdx55.dtsi | 1 +
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 ++-
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +-
> 18 files changed, 264 insertions(+), 227 deletions(-)
>
> --
> 2.34.1
>