2022-09-26 15:48:15

by Daniel Lezcano

Subject: [PATCH v5 04/30] thermal/core: Add a generic thermal_zone_get_crit_temp() function

The thermal zone ops defines a callback to retrieve the critical
temperature. As the trip handling is being reworked, all the trip
points will be the same whatever the driver and consequently finding
the critical trip temperature will be just a loop to search for a
critical trip point type.

Provide such a generic function, so we encapsulate the ops
get_crit_temp() which can be removed when all the backend drivers are
using the generic trip points handling.

Signed-off-by: Daniel Lezcano <[email protected]>
Reviewed-by: Zhang Rui <[email protected]>
---
include/linux/thermal.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 5350a437f245..66373f872237 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -343,6 +343,8 @@ int thermal_zone_set_trip(struct thermal_zone_device *tz, int trip_id,

int thermal_zone_get_num_trips(struct thermal_zone_device *tz);

+int thermal_zone_get_crit_temp(struct thermal_zone_device *tz, int *temp);
+
#ifdef CONFIG_THERMAL
struct thermal_zone_device *thermal_zone_device_register(const char *, int, int,
void *, struct thermal_zone_device_ops *,
--
2.34.1

2022-09-26 19:37:09

by Rafael J. Wysocki

Subject: Re: [PATCH v5 04/30] thermal/core: Add a generic thermal_zone_get_crit_temp() function

On Mon, Sep 26, 2022 at 4:06 PM Daniel Lezcano
<[email protected]> wrote:
>
> The thermal zone ops defines a callback to retrieve the critical
> temperature. As the trip handling is being reworked, all the trip
> points will be the same whatever the driver and consequently finding
> the critical trip temperature will be just a loop to search for a
> critical trip point type.
>
> Provide such a generic function, so we encapsulate the ops
> get_crit_temp() which can be removed when all the backend drivers are
> using the generic trip points handling.
>
> Signed-off-by: Daniel Lezcano <[email protected]>
> Reviewed-by: Zhang Rui <[email protected]>
> ---
> include/linux/thermal.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 5350a437f245..66373f872237 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -343,6 +343,8 @@ int thermal_zone_set_trip(struct thermal_zone_device *tz, int trip_id,
>
> int thermal_zone_get_num_trips(struct thermal_zone_device *tz);
>
> +int thermal_zone_get_crit_temp(struct thermal_zone_device *tz, int *temp);
> +

Well, this only adds a function header which by itself is not
particularly useful (and the code change doesn't match the changelog
even), so I would fold it into the patch that actually adds the
function, including its body.

> #ifdef CONFIG_THERMAL
> struct thermal_zone_device *thermal_zone_device_register(const char *, int, int,
> void *, struct thermal_zone_device_ops *,
> --
> 2.34.1
>