2022-10-17 10:07:07

by Jiapeng Chong

Subject: [PATCH] drm/amdgpu: Remove the unused function amdgpu_ucode_print_imu_hdr()

The function amdgpu_ucode_print_imu_hdr() is defined in the amdgpu_ucode.c
file, but not called elsewhere, so delete this unused function.

drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:129:6: warning: no previous prototype for function 'amdgpu_ucode_print_imu_hdr'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2416
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
index dd0bc649a57d..148cc2d475c5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
@@ -126,19 +126,6 @@ void amdgpu_ucode_print_gfx_hdr(const struct common_firmware_header *hdr)
}
}

-void amdgpu_ucode_print_imu_hdr(const struct common_firmware_header *hdr)
-{
- uint16_t version_major = le16_to_cpu(hdr->header_version_major);
- uint16_t version_minor = le16_to_cpu(hdr->header_version_minor);
-
- DRM_DEBUG("IMU\n");
- amdgpu_ucode_print_common_hdr(hdr);
-
- if (version_major != 1) {
- DRM_ERROR("Unknown GFX ucode version: %u.%u\n", version_major, version_minor);
- }
-}
-
void amdgpu_ucode_print_rlc_hdr(const struct common_firmware_header *hdr)
{
uint16_t version_major = le16_to_cpu(hdr->header_version_major);
--
2.20.1.7.g153144c

2022-10-17 15:57:46

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: Remove the unused function amdgpu_ucode_print_imu_hdr()

On Mon, Oct 17, 2022 at 5:04 AM Jiapeng Chong
<[email protected]> wrote:
>
> The function amdgpu_ucode_print_imu_hdr() is defined in the amdgpu_ucode.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:129:6: warning: no previous prototype for function 'amdgpu_ucode_print_imu_hdr'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2416
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Alex Deucher <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index dd0bc649a57d..148cc2d475c5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -126,19 +126,6 @@ void amdgpu_ucode_print_gfx_hdr(const struct common_firmware_header *hdr)
> }
> }
>
> -void amdgpu_ucode_print_imu_hdr(const struct common_firmware_header *hdr)
> -{
> - uint16_t version_major = le16_to_cpu(hdr->header_version_major);
> - uint16_t version_minor = le16_to_cpu(hdr->header_version_minor);
> -
> - DRM_DEBUG("IMU\n");
> - amdgpu_ucode_print_common_hdr(hdr);
> -
> - if (version_major != 1) {
> - DRM_ERROR("Unknown GFX ucode version: %u.%u\n", version_major, version_minor);
> - }
> -}
> -
> void amdgpu_ucode_print_rlc_hdr(const struct common_firmware_header *hdr)
> {
> uint16_t version_major = le16_to_cpu(hdr->header_version_major);
> --
> 2.20.1.7.g153144c
>