2022-10-18 14:52:45

by Ye Bin

Subject: [PATCH v2 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'

As previous commit, 'blk_trace_cleanup' will stop block trace if
block trace's state is 'Blktrace_running'.
So remove unnessary stop block trace in 'blk_trace_shutdown'.

Signed-off-by: Ye Bin <[email protected]>
---
kernel/trace/blktrace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 030e5716661e..2be8c747f796 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -784,10 +784,8 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
void blk_trace_shutdown(struct request_queue *q)
{
if (rcu_dereference_protected(q->blk_trace,
- lockdep_is_held(&q->debugfs_mutex))) {
- __blk_trace_startstop(q, 0);
+ lockdep_is_held(&q->debugfs_mutex)))
__blk_trace_remove(q);
- }
}

#ifdef CONFIG_BLK_CGROUP
--
2.31.1

2022-10-18 15:57:39

by Christoph Hellwig

Subject: Re: [PATCH v2 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>