2022-10-21 09:08:29

by Jingbo Xu

Subject: [PATCH 1/2] netfs: export helpers for request and subrequest

Export netfs_put_subrequest() and netfs_rreq_completed().

Signed-off-by: Jingbo Xu <[email protected]>
---
fs/netfs/io.c | 3 ++-
fs/netfs/objects.c | 1 +
include/linux/netfs.h | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/netfs/io.c b/fs/netfs/io.c
index 428925899282..58dd56e3e780 100644
--- a/fs/netfs/io.c
+++ b/fs/netfs/io.c
@@ -94,12 +94,13 @@ static void netfs_read_from_server(struct netfs_io_request *rreq,
/*
* Release those waiting.
*/
-static void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async)
+void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async)
{
trace_netfs_rreq(rreq, netfs_rreq_trace_done);
netfs_clear_subrequests(rreq, was_async);
netfs_put_request(rreq, was_async, netfs_rreq_trace_put_complete);
}
+EXPORT_SYMBOL(netfs_rreq_completed);

/*
* Deal with the completion of writing the data to the cache. We have to clear
diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c
index e17cdf53f6a7..478cc1a1664c 100644
--- a/fs/netfs/objects.c
+++ b/fs/netfs/objects.c
@@ -158,3 +158,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async,
if (dead)
netfs_free_subrequest(subreq, was_async);
}
+EXPORT_SYMBOL(netfs_put_subrequest);
diff --git a/include/linux/netfs.h b/include/linux/netfs.h
index f2402ddeafbf..d519fb709d7f 100644
--- a/include/linux/netfs.h
+++ b/include/linux/netfs.h
@@ -282,6 +282,8 @@ int netfs_write_begin(struct netfs_inode *, struct file *,
struct address_space *, loff_t pos, unsigned int len,
struct folio **, void **fsdata);

+void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async);
+
void netfs_subreq_terminated(struct netfs_io_subrequest *, ssize_t, bool);
void netfs_get_subrequest(struct netfs_io_subrequest *subreq,
enum netfs_sreq_ref_trace what);
--
2.19.1.6.gb485710b

2022-10-21 09:52:41

by Gao Xiang

Subject: Re: [PATCH 1/2] netfs: export helpers for request and subrequest

On Fri, Oct 21, 2022 at 04:49:11PM +0800, Jingbo Xu wrote:
> Export netfs_put_subrequest() and netfs_rreq_completed().
>
> Signed-off-by: Jingbo Xu <[email protected]>

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

> ---
> fs/netfs/io.c | 3 ++-
> fs/netfs/objects.c | 1 +
> include/linux/netfs.h | 2 ++
> 3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/netfs/io.c b/fs/netfs/io.c
> index 428925899282..58dd56e3e780 100644
> --- a/fs/netfs/io.c
> +++ b/fs/netfs/io.c
> @@ -94,12 +94,13 @@ static void netfs_read_from_server(struct netfs_io_request *rreq,
> /*
> * Release those waiting.
> */
> -static void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async)
> +void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async)
> {
> trace_netfs_rreq(rreq, netfs_rreq_trace_done);
> netfs_clear_subrequests(rreq, was_async);
> netfs_put_request(rreq, was_async, netfs_rreq_trace_put_complete);
> }
> +EXPORT_SYMBOL(netfs_rreq_completed);
>
> /*
> * Deal with the completion of writing the data to the cache. We have to clear
> diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c
> index e17cdf53f6a7..478cc1a1664c 100644
> --- a/fs/netfs/objects.c
> +++ b/fs/netfs/objects.c
> @@ -158,3 +158,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async,
> if (dead)
> netfs_free_subrequest(subreq, was_async);
> }
> +EXPORT_SYMBOL(netfs_put_subrequest);
> diff --git a/include/linux/netfs.h b/include/linux/netfs.h
> index f2402ddeafbf..d519fb709d7f 100644
> --- a/include/linux/netfs.h
> +++ b/include/linux/netfs.h
> @@ -282,6 +282,8 @@ int netfs_write_begin(struct netfs_inode *, struct file *,
> struct address_space *, loff_t pos, unsigned int len,
> struct folio **, void **fsdata);
>
> +void netfs_rreq_completed(struct netfs_io_request *rreq, bool was_async);
> +
> void netfs_subreq_terminated(struct netfs_io_subrequest *, ssize_t, bool);
> void netfs_get_subrequest(struct netfs_io_subrequest *subreq,
> enum netfs_sreq_ref_trace what);
> --
> 2.19.1.6.gb485710b