2022-10-25 08:12:50

by Claudiu Beznea

[permalink] [raw]
Subject: [PATCH] nvmem: lan9662-otp: fix compatible name

Documentation of lan9662-otpc driver (namely Documentation/\
devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
compatible for this driver contains "otpc" string at the end but not "otp"
as currently present. Fix this typo.

Fixes: 9e8f208ad522 ("nvmem: lan9662-otp: add support")
Signed-off-by: Claudiu Beznea <[email protected]>
---
drivers/nvmem/lan9662-otpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/lan9662-otpc.c b/drivers/nvmem/lan9662-otpc.c
index f6732fd216d8..377bf34c2946 100644
--- a/drivers/nvmem/lan9662-otpc.c
+++ b/drivers/nvmem/lan9662-otpc.c
@@ -203,7 +203,7 @@ static int lan9662_otp_probe(struct platform_device *pdev)
}

static const struct of_device_id lan9662_otp_match[] = {
- { .compatible = "microchip,lan9662-otp", },
+ { .compatible = "microchip,lan9662-otpc", },
{ },
};
MODULE_DEVICE_TABLE(of, lan9662_otp_match);
--
2.34.1



2022-10-26 00:13:32

by Horatiu Vultur

[permalink] [raw]
Subject: Re: [PATCH] nvmem: lan9662-otp: fix compatible name

The 10/25/2022 10:22, Claudiu Beznea wrote:

Hi Claudiu,

> Documentation of lan9662-otpc driver (namely Documentation/\
> devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
> compatible for this driver contains "otpc" string at the end but not "otp"
> as currently present. Fix this typo.

Thanks for this patch.
I have also sent a patch for this some time ago[1], but there
is no reply on this.

Anyway for this patch:

Reviewed-by: Horatiu Vultur <[email protected]>

[1] https://patchew.org/linux/[email protected]/

>
> Fixes: 9e8f208ad522 ("nvmem: lan9662-otp: add support")
> Signed-off-by: Claudiu Beznea <[email protected]>
> ---
> drivers/nvmem/lan9662-otpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/lan9662-otpc.c b/drivers/nvmem/lan9662-otpc.c
> index f6732fd216d8..377bf34c2946 100644
> --- a/drivers/nvmem/lan9662-otpc.c
> +++ b/drivers/nvmem/lan9662-otpc.c
> @@ -203,7 +203,7 @@ static int lan9662_otp_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id lan9662_otp_match[] = {
> - { .compatible = "microchip,lan9662-otp", },
> + { .compatible = "microchip,lan9662-otpc", },
> { },
> };
> MODULE_DEVICE_TABLE(of, lan9662_otp_match);
> --
> 2.34.1
>

--
/Horatiu

2022-11-10 18:02:56

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] nvmem: lan9662-otp: fix compatible name

On Wed, Oct 26, 2022 at 01:44:05AM +0200, Horatiu Vultur wrote:
> The 10/25/2022 10:22, Claudiu Beznea wrote:
>
> Hi Claudiu,
>
> > Documentation of lan9662-otpc driver (namely Documentation/\
> > devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml) express that
> > compatible for this driver contains "otpc" string at the end but not "otp"
> > as currently present. Fix this typo.
>
> Thanks for this patch.
> I have also sent a patch for this some time ago[1], but there
> is no reply on this.
>
> Anyway for this patch:
>
> Reviewed-by: Horatiu Vultur <[email protected]>
>
> [1] https://patchew.org/linux/[email protected]/

I have queued up your first patch as you were here first, thanks.

greg k-h