2022-10-25 09:06:43

by 李扬韬

Subject: [PATCH v3] f2fs: cleanup in f2fs_create_flush_cmd_control()

Just cleanup for readable, no functional changes.

Suggested-by: Chao Yu <[email protected]>
Signed-off-by: Yangtao Li <[email protected]>
---
v3:
-avoid UAF
fs/f2fs/segment.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index acf3d3fa4363..84a17607dfee 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -620,12 +620,12 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
{
dev_t dev = sbi->sb->s_bdev->bd_dev;
struct flush_cmd_control *fcc;
- int err = 0;
+ int err;

if (SM_I(sbi)->fcc_info) {
fcc = SM_I(sbi)->fcc_info;
if (fcc->f2fs_issue_flush)
- return err;
+ return 0;
goto init_thread;
}

@@ -638,7 +638,7 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
init_llist_head(&fcc->issue_list);
SM_I(sbi)->fcc_info = fcc;
if (!test_opt(sbi, FLUSH_MERGE))
- return err;
+ return 0;

init_thread:
fcc->f2fs_issue_flush = kthread_run(issue_flush_thread, sbi,
@@ -650,7 +650,7 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
return err;
}

- return err;
+ return 0;
}

void f2fs_destroy_flush_cmd_control(struct f2fs_sb_info *sbi, bool free)
--
2.25.1

2022-10-25 10:37:22

by Chao Yu

Subject: Re: [PATCH v3] f2fs: cleanup in f2fs_create_flush_cmd_control()

On 2022/10/25 16:05, Yangtao Li wrote:
> Just cleanup for readable, no functional changes.
>
> Suggested-by: Chao Yu <[email protected]>
> Signed-off-by: Yangtao Li <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,