When a fatal error occurs in the file system and it is
remounted to ro mode, the flush thread needs to be stopped.
Fixes: d81ab30e85a5 ("f2fs: support errors=remount-ro|continue|panic mountoption")
Signed-off-by: Yangtao Li <[email protected]>
---
fs/f2fs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index fc220b5c5599..3a1238a82dc9 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -4017,6 +4017,7 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason,
f2fs_stop_gc_thread(sbi);
f2fs_stop_discard_thread(sbi);
+ f2fs_stop_flush_thread(sbi);
}
static void f2fs_record_error_work(struct work_struct *work)
--
2.25.1
On 2022/10/27 20:08, Yangtao Li wrote:
> When a fatal error occurs in the file system and it is
> remounted to ro mode, the flush thread needs to be stopped.
>
> Fixes: d81ab30e85a5 ("f2fs: support errors=remount-ro|continue|panic mountoption")
Do you mind letting me merge these two patches into original patch?
since original patch is still in dev branch, rather than mainline.
I guess it needs to stop ckpt thread as well...
Thanks,
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index fc220b5c5599..3a1238a82dc9 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4017,6 +4017,7 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason,
>
> f2fs_stop_gc_thread(sbi);
> f2fs_stop_discard_thread(sbi);
> + f2fs_stop_flush_thread(sbi);
> }
>
> static void f2fs_record_error_work(struct work_struct *work)
> It won't pollute global namespace since it's a static function just be used in f2fs/super.c...
emm, I think it would be nice to see the f2fs_record_error_work symbol
in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.
> Do you mind letting me merge these two patches into original patch?
> since original patch is still in dev branch, rather than mainline.
Glad to see, if resend.
> I guess it needs to stop ckpt thread as well...
agree, :)
Thanks,
On 2022/10/28 10:33, Yangtao Li wrote:
>> It won't pollute global namespace since it's a static function just be used in f2fs/super.c...
>
> emm, I think it would be nice to see the f2fs_record_error_work symbol
> in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.
Oh, yes, let me update in original patch as well.
>
>> Do you mind letting me merge these two patches into original patch?
>> since original patch is still in dev branch, rather than mainline.
>
> Glad to see, if resend.
Thanks, :)
>
>> I guess it needs to stop ckpt thread as well...
>
> agree, :)
>
> Thanks,
On 10/28, Chao Yu wrote:
> On 2022/10/28 10:33, Yangtao Li wrote:
> > > It won't pollute global namespace since it's a static function just be used in f2fs/super.c...
> >
> > emm, I think it would be nice to see the f2fs_record_error_work symbol
> > in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.
>
> Oh, yes, let me update in original patch as well.
Chao,
It seems there're multiple bugs. Please apply this as well.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#u
>
> >
> > > Do you mind letting me merge these two patches into original patch?
> > > since original patch is still in dev branch, rather than mainline.
> >
> > Glad to see, if resend.
>
> Thanks, :)
>
> >
> > > I guess it needs to stop ckpt thread as well...
> >
> > agree, :)
> >
> > Thanks,
On 2022/10/28 11:17, Jaegeuk Kim wrote:
> On 10/28, Chao Yu wrote:
>> On 2022/10/28 10:33, Yangtao Li wrote:
>>>> It won't pollute global namespace since it's a static function just be used in f2fs/super.c...
>>>
>>> emm, I think it would be nice to see the f2fs_record_error_work symbol
>>> in the stack, it can be explicitly a function of f2fs. personal opinion for reference only.
>>
>> Oh, yes, let me update in original patch as well.
>
> Chao,
>
> It seems there're multiple bugs. Please apply this as well.
>
> https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#u
Jaegeuk,
Thanks, let me merge all those patches and do the test.
Thanks,
>
>>
>>>
>>>> Do you mind letting me merge these two patches into original patch?
>>>> since original patch is still in dev branch, rather than mainline.
>>>
>>> Glad to see, if resend.
>>
>> Thanks, :)
>>
>>>
>>>> I guess it needs to stop ckpt thread as well...
>>>
>>> agree, :)
>>>
>>> Thanks,