2022-10-22 06:32:45

by Christophe JAILLET

Subject: [PATCH] soc: imx: imx93-pd: Fix the error handling path of imx93_pd_probe()

In imx93_pd_probe(); if an error occurs, some resources need to be released
as done in the remove function.

Fixes: 0a0f7cc25d4a ("soc: imx: add i.MX93 SRC power domain driver")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/soc/imx/imx93-pd.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/imx/imx93-pd.c b/drivers/soc/imx/imx93-pd.c
index 1f3d7039c1de..4d235c8c4924 100644
--- a/drivers/soc/imx/imx93-pd.c
+++ b/drivers/soc/imx/imx93-pd.c
@@ -135,11 +135,24 @@ static int imx93_pd_probe(struct platform_device *pdev)

ret = pm_genpd_init(&domain->genpd, NULL, domain->init_off);
if (ret)
- return ret;
+ goto err_clk_unprepare;

platform_set_drvdata(pdev, domain);

- return of_genpd_add_provider_simple(np, &domain->genpd);
+ ret = of_genpd_add_provider_simple(np, &domain->genpd);
+ if (ret)
+ goto err_genpd_remove;
+
+ return 0;
+
+err_genpd_remove:
+ pm_genpd_remove(&domain->genpd);
+
+err_clk_unprepare:
+ if (!domain->init_off)
+ clk_bulk_disable_unprepare(domain->num_clks, domain->clks);
+
+ return ret;
}

static const struct of_device_id imx93_pd_ids[] = {
--
2.34.1

2022-10-29 08:40:00

by Shawn Guo

Subject: Re: [PATCH] soc: imx: imx93-pd: Fix the error handling path of imx93_pd_probe()

On Sat, Oct 22, 2022 at 08:08:55AM +0200, Christophe JAILLET wrote:
> In imx93_pd_probe(); if an error occurs, some resources need to be released
> as done in the remove function.
>
> Fixes: 0a0f7cc25d4a ("soc: imx: add i.MX93 SRC power domain driver")
> Signed-off-by: Christophe JAILLET <[email protected]>

Applied, thanks!