Add the touchscreen now, since the driver is available.
Signed-off-by: Andreas Kemnade <[email protected]>
---
runtime/dtbs_check depends
https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++-
arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
3 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
index 935e2359f8df..4f36cc181a52 100644
--- a/arch/arm/boot/dts/e60k02.dtsi
+++ b/arch/arm/boot/dts/e60k02.dtsi
@@ -104,7 +104,17 @@ &i2c2 {
clock-frequency = <100000>;
status = "okay";
- /* TODO: CYTTSP5 touch controller at 0x24 */
+ touchscreen@24 {
+ compatible = "cypress,tt21000";
+ reg = <0x24>;
+ pinctrl-names = "default","sleep";
+ pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
+ pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
+ interrupt-parent = <&gpio5>;
+ interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+ reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&ldo5_reg>;
+ };
/* TODO: TPS65185 PMIC for E Ink at 0x68 */
diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
index e3f1e8d79528..82d9ed91df92 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
@@ -52,6 +52,20 @@ &iomuxc {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hog>;
+ pinctrl_cyttsp5_gpio: cyttsp5_gpio_grp {
+ fsl,pins = <
+ MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x17059 /* TP_INT */
+ MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
+ >;
+ };
+
+ pinctrl_cyttsp5_gpio_sleep: cyttsp5_gpio_grp_sleep {
+ fsl,pins = <
+ MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x10059 /* TP_INT */
+ MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
+ >;
+ };
+
pinctrl_gpio_keys: gpio-keysgrp {
fsl,pins = <
MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059 /* PWR_SW */
diff --git a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
index 90b32f5eb529..d743bf4fd8e6 100644
--- a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
+++ b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
@@ -62,6 +62,20 @@ &iomuxc {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hog>;
+ pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp {
+ fsl,pins = <
+ MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x17059 /* TP_INT */
+ MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
+ >;
+ };
+
+ pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpiogrp-sleep {
+ fsl,pins = <
+ MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x10059 /* TP_INT */
+ MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
+ >;
+ };
+
pinctrl_gpio_keys: gpio-keysgrp {
fsl,pins = <
MX6SLL_PAD_SD1_DATA1__GPIO5_IO08 0x17059 /* PWR_SW */
--
2.30.2
Hi Marco,
On Wed, 26 Oct 2022 19:43:00 +0200
Marco Felsch <[email protected]> wrote:
> Hi Andreas,
>
> On 22-10-26, Andreas Kemnade wrote:
> > Add the touchscreen now, since the driver is available.
>
> I pulled input/next and grep'ed for the compatible but found nothing.
> Where should the driver be available?
>
Copying the link again.
I have the guts feeling that it is near being accepted:
https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
Regards,
Andreas
> Regards,
> Marco
>
> > Signed-off-by: Andreas Kemnade <[email protected]>
> > ---
> > runtime/dtbs_check depends
> > https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> > arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++-
> > arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> > 3 files changed, 39 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
> > index 935e2359f8df..4f36cc181a52 100644
> > --- a/arch/arm/boot/dts/e60k02.dtsi
> > +++ b/arch/arm/boot/dts/e60k02.dtsi
> > @@ -104,7 +104,17 @@ &i2c2 {
> > clock-frequency = <100000>;
> > status = "okay";
> >
> > - /* TODO: CYTTSP5 touch controller at 0x24 */
> > + touchscreen@24 {
> > + compatible = "cypress,tt21000";
> > + reg = <0x24>;
> > + pinctrl-names = "default","sleep";
>
> Does the driver handle the different states?
>
> > + pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
> > + pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
> > + interrupt-parent = <&gpio5>;
> > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> > + reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> > + vdd-supply = <&ldo5_reg>;
> > + };
> >
> > /* TODO: TPS65185 PMIC for E Ink at 0x68 */
> >
> > diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> > index e3f1e8d79528..82d9ed91df92 100644
> > --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> > +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> > @@ -52,6 +52,20 @@ &iomuxc {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_hog>;
> >
> > + pinctrl_cyttsp5_gpio: cyttsp5_gpio_grp {
>
> According the below code it should be:
> pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp {
>
> and..
>
> > + fsl,pins = <
> > + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x17059 /* TP_INT */
> > + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
> > + >;
> > + };
> > +
> > + pinctrl_cyttsp5_gpio_sleep: cyttsp5_gpio_grp_sleep {
>
>
> pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpio-sleepgrp {
>
>
> Regards,
> Marco
>
> > + fsl,pins = <
> > + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x10059 /* TP_INT */
> > + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
> > + >;
> > + };
> > +
> > pinctrl_gpio_keys: gpio-keysgrp {
> > fsl,pins = <
> > MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059 /* PWR_SW */
> > diff --git a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> > index 90b32f5eb529..d743bf4fd8e6 100644
> > --- a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> > +++ b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> > @@ -62,6 +62,20 @@ &iomuxc {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_hog>;
> >
> > + pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp {
> > + fsl,pins = <
> > + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x17059 /* TP_INT */
> > + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
> > + >;
> > + };
> > +
> > + pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpiogrp-sleep {
> > + fsl,pins = <
> > + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x10059 /* TP_INT */
> > + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
> > + >;
> > + };
> > +
> > pinctrl_gpio_keys: gpio-keysgrp {
> > fsl,pins = <
> > MX6SLL_PAD_SD1_DATA1__GPIO5_IO08 0x17059 /* PWR_SW */
> > --
> > 2.30.2
> >
> >
> >
>
On 26/10/2022 13:30, Andreas Kemnade wrote:
> Add the touchscreen now, since the driver is available.
>
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> runtime/dtbs_check depends
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++-
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> 3 files changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
> index 935e2359f8df..4f36cc181a52 100644
> --- a/arch/arm/boot/dts/e60k02.dtsi
> +++ b/arch/arm/boot/dts/e60k02.dtsi
> @@ -104,7 +104,17 @@ &i2c2 {
> clock-frequency = <100000>;
> status = "okay";
>
> - /* TODO: CYTTSP5 touch controller at 0x24 */
> + touchscreen@24 {
> + compatible = "cypress,tt21000";
> + reg = <0x24>;
> + pinctrl-names = "default","sleep";
> + pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
> + pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&ldo5_reg>;
> + };
>
> /* TODO: TPS65185 PMIC for E Ink at 0x68 */
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> index e3f1e8d79528..82d9ed91df92 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -52,6 +52,20 @@ &iomuxc {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hog>;
>
> + pinctrl_cyttsp5_gpio: cyttsp5_gpio_grp {
No underscores in node names.
Best regards,
Krzysztof
Hi Andreas,
On 22-10-26, Andreas Kemnade wrote:
> Add the touchscreen now, since the driver is available.
I pulled input/next and grep'ed for the compatible but found nothing.
Where should the driver be available?
Regards,
Marco
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> runtime/dtbs_check depends
> https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++-
> arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> 3 files changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
> index 935e2359f8df..4f36cc181a52 100644
> --- a/arch/arm/boot/dts/e60k02.dtsi
> +++ b/arch/arm/boot/dts/e60k02.dtsi
> @@ -104,7 +104,17 @@ &i2c2 {
> clock-frequency = <100000>;
> status = "okay";
>
> - /* TODO: CYTTSP5 touch controller at 0x24 */
> + touchscreen@24 {
> + compatible = "cypress,tt21000";
> + reg = <0x24>;
> + pinctrl-names = "default","sleep";
Does the driver handle the different states?
> + pinctrl-0 = <&pinctrl_cyttsp5_gpio>;
> + pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> + reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&ldo5_reg>;
> + };
>
> /* TODO: TPS65185 PMIC for E Ink at 0x68 */
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> index e3f1e8d79528..82d9ed91df92 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
> @@ -52,6 +52,20 @@ &iomuxc {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hog>;
>
> + pinctrl_cyttsp5_gpio: cyttsp5_gpio_grp {
According the below code it should be:
pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp {
and..
> + fsl,pins = <
> + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x17059 /* TP_INT */
> + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
> + >;
> + };
> +
> + pinctrl_cyttsp5_gpio_sleep: cyttsp5_gpio_grp_sleep {
pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpio-sleepgrp {
Regards,
Marco
> + fsl,pins = <
> + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x10059 /* TP_INT */
> + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */
> + >;
> + };
> +
> pinctrl_gpio_keys: gpio-keysgrp {
> fsl,pins = <
> MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059 /* PWR_SW */
> diff --git a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> index 90b32f5eb529..d743bf4fd8e6 100644
> --- a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> +++ b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts
> @@ -62,6 +62,20 @@ &iomuxc {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hog>;
>
> + pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp {
> + fsl,pins = <
> + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x17059 /* TP_INT */
> + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
> + >;
> + };
> +
> + pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpiogrp-sleep {
> + fsl,pins = <
> + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x10059 /* TP_INT */
> + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */
> + >;
> + };
> +
> pinctrl_gpio_keys: gpio-keysgrp {
> fsl,pins = <
> MX6SLL_PAD_SD1_DATA1__GPIO5_IO08 0x17059 /* PWR_SW */
> --
> 2.30.2
>
>
>
On Wed, Oct 26, 2022 at 07:30:15PM +0200, Andreas Kemnade wrote:
> Add the touchscreen now, since the driver is available.
>
> Signed-off-by: Andreas Kemnade <[email protected]>
We idiomatically prefix i.MX arm DTS patch like 'ARM: dts: ...'
Shawn
Hi Marco,
Am Wed, 26 Oct 2022 19:43:00 +0200
schrieb Marco Felsch <[email protected]>:
> Hi Andreas,
>
> On 22-10-26, Andreas Kemnade wrote:
> > Add the touchscreen now, since the driver is available.
>
> I pulled input/next and grep'ed for the compatible but found nothing.
> Where should the driver be available?
now it is in input/next, so time to clean up this one here, too.
> Regards,
> Marco
>
> > Signed-off-by: Andreas Kemnade <[email protected]>
> > ---
> > runtime/dtbs_check depends
> > https://lore.kernel.org/linux-devicetree/[email protected]/T/#t
> > arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++-
> > arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> > 3 files changed, 39 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/e60k02.dtsi
> > b/arch/arm/boot/dts/e60k02.dtsi index 935e2359f8df..4f36cc181a52
> > 100644 --- a/arch/arm/boot/dts/e60k02.dtsi
> > +++ b/arch/arm/boot/dts/e60k02.dtsi
> > @@ -104,7 +104,17 @@ &i2c2 {
> > clock-frequency = <100000>;
> > status = "okay";
> >
> > - /* TODO: CYTTSP5 touch controller at 0x24 */
> > + touchscreen@24 {
> > + compatible = "cypress,tt21000";
> > + reg = <0x24>;
> > + pinctrl-names = "default","sleep";
>
> Does the driver handle the different states?
>
Well, apparently not, just copied it over from vendor kernel driver
which also does not handle that... So just leaving it out for now.
Regards,
Andreas