2022-11-02 16:01:38

by Johan Hovold

Subject: [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message

Drivers should not be logging errors on probe deferral. Switch to using
dev_err_probe() to log failures when parsing the devicetree to avoid
errors like:

qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517

when a channel is not yet available.

Signed-off-by: Johan Hovold <[email protected]>
---
drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index a3310bf061cb..c70615d2d771 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -1031,10 +1031,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
return irq;

ret = adc_tm5_get_dt_data(adc_tm, node);
- if (ret) {
- dev_err(dev, "get dt data failed: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "get dt data failed\n");

ret = adc_tm->data->init(adc_tm);
if (ret) {
--
2.37.3

2022-11-02 16:17:18

by Andrew Halaney

Subject: Re: [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message

On Wed, Nov 02, 2022 at 04:26:30PM +0100, Johan Hovold wrote:
> Drivers should not be logging errors on probe deferral. Switch to using
> dev_err_probe() to log failures when parsing the devicetree to avoid
> errors like:
>
> qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517
>
> when a channel is not yet available.
>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Andrew Halaney <[email protected]>

> ---
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index a3310bf061cb..c70615d2d771 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -1031,10 +1031,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
> return irq;
>
> ret = adc_tm5_get_dt_data(adc_tm, node);
> - if (ret) {
> - dev_err(dev, "get dt data failed: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "get dt data failed\n");
>
> ret = adc_tm->data->init(adc_tm);
> if (ret) {
> --
> 2.37.3
>

2022-11-02 16:35:58

by Manivannan Sadhasivam

Subject: Re: [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message

On Wed, Nov 02, 2022 at 04:26:30PM +0100, Johan Hovold wrote:
> Drivers should not be logging errors on probe deferral. Switch to using
> dev_err_probe() to log failures when parsing the devicetree to avoid
> errors like:
>
> qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517
>
> when a channel is not yet available.
>
> Signed-off-by: Johan Hovold <[email protected]>

I did send a patch earlier for fixing this same issue but I did not use
dev_err_probe(). So yours is better.

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index a3310bf061cb..c70615d2d771 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -1031,10 +1031,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
> return irq;
>
> ret = adc_tm5_get_dt_data(adc_tm, node);
> - if (ret) {
> - dev_err(dev, "get dt data failed: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "get dt data failed\n");
>
> ret = adc_tm->data->init(adc_tm);
> if (ret) {
> --
> 2.37.3
>

--
மணிவண்ணன் சதாசிவம்

2022-11-30 07:25:26

by Johan Hovold

Subject: Re: [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message

On Wed, Nov 02, 2022 at 04:26:30PM +0100, Johan Hovold wrote:
> Drivers should not be logging errors on probe deferral. Switch to using
> dev_err_probe() to log failures when parsing the devicetree to avoid
> errors like:
>
> qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517
>
> when a channel is not yet available.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index a3310bf061cb..c70615d2d771 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -1031,10 +1031,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
> return irq;
>
> ret = adc_tm5_get_dt_data(adc_tm, node);
> - if (ret) {
> - dev_err(dev, "get dt data failed: %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "get dt data failed\n");
>
> ret = adc_tm->data->init(adc_tm);
> if (ret) {

Daniel, I noticed this one hasn't been picked up yet (at least it's not
in linux-next). Is this something you can do?

Johan

2022-12-04 17:11:44

by Daniel Lezcano

Subject: Re: [PATCH] thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message

On 02/11/2022 16:26, Johan Hovold wrote:
> Drivers should not be logging errors on probe deferral. Switch to using
> dev_err_probe() to log failures when parsing the devicetree to avoid
> errors like:
>
> qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517
>
> when a channel is not yet available.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog