2022-11-07 22:10:54

by Serge Semin

[permalink] [raw]
Subject: [PATCH] dt-bindings: opp-v2: Fix clock-latency-ns prop in example

Accidentally discovered a hidden typo in the DT-nodes defined in the
opp-v2 bindings example. Instead of specifying the "clock-latency-ns"
property the DT-node has been created with the "lock-latency-ns" property
in it, which doesn't exist neither in opp-v2 nor in the base schemas.
Let's fix the name to having the "clock-" prefix as it was originally
implied and as the rest of the similar nodes has.

Fixes: 94274f20f6bf ("dt-bindings: opp: Convert to DT schema")
Signed-off-by: Serge Semin <[email protected]>

---

Note unevaluatedProperties flag hasn't revealed the problem here most
likely due to the property having the "-ns" suffix which implies the
property being single-number. It is implicitly evaluated by the dt-schema
core thus preventing the unevaluatedProperties schema to detect the
inconsistency.
---
Documentation/devicetree/bindings/opp/opp-v2.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/opp/opp-v2.yaml b/Documentation/devicetree/bindings/opp/opp-v2.yaml
index eaf8fba2c691..2f05920fce79 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2.yaml
@@ -155,7 +155,7 @@ examples:
opp-hz = /bits/ 64 <1200000000>;
opp-microvolt = <1025000>;
opp-microamp = <90000>;
- lock-latency-ns = <290000>;
+ clock-latency-ns = <290000>;
turbo-mode;
};
};
--
2.38.0




2022-11-08 04:37:39

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: opp-v2: Fix clock-latency-ns prop in example

On 07-11-22, 23:43, Serge Semin wrote:
> Accidentally discovered a hidden typo in the DT-nodes defined in the
> opp-v2 bindings example. Instead of specifying the "clock-latency-ns"
> property the DT-node has been created with the "lock-latency-ns" property
> in it, which doesn't exist neither in opp-v2 nor in the base schemas.
> Let's fix the name to having the "clock-" prefix as it was originally
> implied and as the rest of the similar nodes has.
>
> Fixes: 94274f20f6bf ("dt-bindings: opp: Convert to DT schema")
> Signed-off-by: Serge Semin <[email protected]>

Applied. Thanks.

--
viresh