2022-11-23 10:56:01

by Ye Bin

Subject: [PATCH] mmc: mmc_test: fix missing assignment of 'file' when register debugfs file

From: Ye Bin <[email protected]>

Now, 'file' is always NULL. obviously, 'file' is used to store return value of
'debugfs_create_file()'.

Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
Signed-off-by: Ye Bin <[email protected]>
---
drivers/mmc/core/mmc_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index 6cd6f8a94a71..156d34b2ed4d 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
struct mmc_test_dbgfs_file *df;

if (card->debugfs_root)
- debugfs_create_file(name, mode, card->debugfs_root, card, fops);
+ file = debugfs_create_file(name, mode, card->debugfs_root,
+ card, fops);

df = kmalloc(sizeof(*df), GFP_KERNEL);
if (!df) {
--
2.31.1

2022-11-23 11:10:20

by Adrian Hunter

Subject: Re: [PATCH] mmc: mmc_test: fix missing assignment of 'file' when register debugfs file

On 23/11/22 11:55, Ye Bin wrote:
> From: Ye Bin <[email protected]>
>
> Now, 'file' is always NULL. obviously, 'file' is used to store return value of
> 'debugfs_create_file()'.

'file' is used to remove debugfs files when the mmc_test module is removed.

>
> Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
> Signed-off-by: Ye Bin <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/core/mmc_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 6cd6f8a94a71..156d34b2ed4d 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
> struct mmc_test_dbgfs_file *df;
>
> if (card->debugfs_root)
> - debugfs_create_file(name, mode, card->debugfs_root, card, fops);
> + file = debugfs_create_file(name, mode, card->debugfs_root,
> + card, fops);
>
> df = kmalloc(sizeof(*df), GFP_KERNEL);
> if (!df) {

2022-11-29 13:00:32

by Ulf Hansson

Subject: Re: [PATCH] mmc: mmc_test: fix missing assignment of 'file' when register debugfs file

On Wed, 23 Nov 2022 at 10:34, Ye Bin <[email protected]> wrote:
>
> From: Ye Bin <[email protected]>
>
> Now, 'file' is always NULL. obviously, 'file' is used to store return value of
> 'debugfs_create_file()'.
>
> Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
> Signed-off-by: Ye Bin <[email protected]>

Applied for fixes, by amending the commit message and by adding a
stable tag, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/core/mmc_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 6cd6f8a94a71..156d34b2ed4d 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3174,7 +3174,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
> struct mmc_test_dbgfs_file *df;
>
> if (card->debugfs_root)
> - debugfs_create_file(name, mode, card->debugfs_root, card, fops);
> + file = debugfs_create_file(name, mode, card->debugfs_root,
> + card, fops);
>
> df = kmalloc(sizeof(*df), GFP_KERNEL);
> if (!df) {
> --
> 2.31.1
>