2022-11-23 18:28:13

by Michael Walle

Subject: [PATCH v4 03/20] of: property: make #.*-cells optional for simple props

Sometimes, future bindings for phandles will get additional arguments.
Thus the target node of the phandle will need a new #.*-cells property.
To be backwards compatible, this needs to be optional.

Prepare the DEFINE_SIMPLE_PROPS() to handle the cells name as optional.

Signed-off-by: Michael Walle <[email protected]>
Tested-by: Miquel Raynal <[email protected]>
---
changes since v3:
- new patch

drivers/of/property.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 967f79b59016..9773bfeaed9f 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1254,8 +1254,8 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np,
if (strcmp_suffix(prop_name, suffix))
return NULL;

- if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
- &sup_args))
+ if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0, index,
+ &sup_args))
return NULL;

return sup_args.np;
--
2.30.2

2022-11-30 01:12:56

by Rob Herring (Arm)

Subject: Re: [PATCH v4 03/20] of: property: make #.*-cells optional for simple props

On Wed, 23 Nov 2022 19:01:34 +0100, Michael Walle wrote:
> Sometimes, future bindings for phandles will get additional arguments.
> Thus the target node of the phandle will need a new #.*-cells property.
> To be backwards compatible, this needs to be optional.
>
> Prepare the DEFINE_SIMPLE_PROPS() to handle the cells name as optional.
>
> Signed-off-by: Michael Walle <[email protected]>
> Tested-by: Miquel Raynal <[email protected]>
> ---
> changes since v3:
> - new patch
>
> drivers/of/property.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>