2022-11-25 04:01:57

by Bagas Sanjaya

[permalink] [raw]
Subject: [PATCH] Documentation/osnoise: escape underscore of NO_ prefix

kernel test robot reported unknown target name warning:

Documentation/trace/osnoise-tracer.rst:112: WARNING: Unknown target name: "no".

The warning causes NO_ prefix to be rendered as link text instead, which
points to non-existent link target.

Escape the prefix underscore to fix the warning.

Link: https://lore.kernel.org/linux-doc/[email protected]/
Fixes: 67543cd6b8eee5 ("Documentation/osnoise: Add osnoise/options documentation")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Bagas Sanjaya <[email protected]>
---
Documentation/trace/osnoise-tracer.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/trace/osnoise-tracer.rst b/Documentation/trace/osnoise-tracer.rst
index 3c675ed82b27ae..fdd562d7c22d18 100644
--- a/Documentation/trace/osnoise-tracer.rst
+++ b/Documentation/trace/osnoise-tracer.rst
@@ -111,7 +111,7 @@ The tracer has a set of options inside the osnoise directory, they are:
be used, which is currently 5 us.
- osnoise/options: a set of on/off options that can be enabled by
writing the option name to the file or disabled by writing the option
- name preceded with the 'NO_' prefix. For example, writing
+ name preceded with the 'NO\_' prefix. For example, writing
NO_OSNOISE_WORKLOAD disables the OSNOISE_WORKLOAD option. The
special DEAFAULTS option resets all options to the default value.


base-commit: bd604f3db49c5b21171abea0414a2020dcbf2646
--
An old man doll... just what I always wanted! - Clara


Subject: Re: [PATCH] Documentation/osnoise: escape underscore of NO_ prefix

On 11/25/22 04:43, Bagas Sanjaya wrote:
> kernel test robot reported unknown target name warning:
>
> Documentation/trace/osnoise-tracer.rst:112: WARNING: Unknown target name: "no".
>
> The warning causes NO_ prefix to be rendered as link text instead, which
> points to non-existent link target.
>
> Escape the prefix underscore to fix the warning.
>
> Link: https://lore.kernel.org/linux-doc/[email protected]/
> Fixes: 67543cd6b8eee5 ("Documentation/osnoise: Add osnoise/options documentation")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Bagas Sanjaya <[email protected]>

Acked-by: Daniel Bristot de Oliveira <[email protected]>

Thanks!
-- Daniel

2022-11-28 21:28:09

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] Documentation/osnoise: escape underscore of NO_ prefix


Jon,

Care to take this?

Acked-by: Steven Rostedt (Google) <[email protected]>

Thanks,

-- Steve


On Fri, 25 Nov 2022 19:16:56 +0100
Daniel Bristot de Oliveira <[email protected]> wrote:

> On 11/25/22 04:43, Bagas Sanjaya wrote:
> > kernel test robot reported unknown target name warning:
> >
> > Documentation/trace/osnoise-tracer.rst:112: WARNING: Unknown target name: "no".
> >
> > The warning causes NO_ prefix to be rendered as link text instead, which
> > points to non-existent link target.
> >
> > Escape the prefix underscore to fix the warning.
> >
> > Link: https://lore.kernel.org/linux-doc/[email protected]/
> > Fixes: 67543cd6b8eee5 ("Documentation/osnoise: Add osnoise/options documentation")
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Bagas Sanjaya <[email protected]>
>
> Acked-by: Daniel Bristot de Oliveira <[email protected]>
>
> Thanks!
> -- Daniel

2022-12-03 10:49:54

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation/osnoise: escape underscore of NO_ prefix

Steven Rostedt <[email protected]> writes:

> Jon,
>
> Care to take this?
>
> Acked-by: Steven Rostedt (Google) <[email protected]>

I was about to, but it doesn't apply here. The problem being fixed
seemingly came in through your tree and currently only exists in
linux-next, so I think you need to apply it.

Thanks,

jon

2022-12-03 13:59:22

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] Documentation/osnoise: escape underscore of NO_ prefix

On Sat, 03 Dec 2022 03:35:39 -0700
Jonathan Corbet <[email protected]> wrote:

> Steven Rostedt <[email protected]> writes:
>
> > Jon,
> >
> > Care to take this?
> >
> > Acked-by: Steven Rostedt (Google) <[email protected]>
>
> I was about to, but it doesn't apply here. The problem being fixed
> seemingly came in through your tree and currently only exists in
> linux-next, so I think you need to apply it.

Thanks, I'll take it then.

-- Steve