2022-11-25 11:26:34

by Tomeu Vizoso

Subject: [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA reset to pwrc

Based on the power sequence in the downstream driver.

Signed-off-by: Tomeu Vizoso <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index 45947c1031c4..fa96fddf4633 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -1625,10 +1625,11 @@ pwrc: power-controller {
<&reset RESET_VDAC>,
<&reset RESET_VDI6>,
<&reset RESET_VENCL>,
- <&reset RESET_VID_LOCK>;
+ <&reset RESET_VID_LOCK>,
+ <&reset RESET_NNA>;
reset-names = "viu", "venc", "vcbus", "bt656",
"rdma", "venci", "vencp", "vdac",
- "vdi6", "vencl", "vid_lock";
+ "vdi6", "vencl", "vid_lock", "nna";
clocks = <&clkc CLKID_VPU>,
<&clkc CLKID_VAPB>;
clock-names = "vpu", "vapb";
--
2.38.1

2022-11-25 13:21:28

by Neil Armstrong

Subject: Re: [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA reset to pwrc

On 25/11/2022 12:19, Tomeu Vizoso wrote:
> Based on the power sequence in the downstream driver.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..fa96fddf4633 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1625,10 +1625,11 @@ pwrc: power-controller {
> <&reset RESET_VDAC>,
> <&reset RESET_VDI6>,
> <&reset RESET_VENCL>,
> - <&reset RESET_VID_LOCK>;
> + <&reset RESET_VID_LOCK>,
> + <&reset RESET_NNA>;

I think this should go in the npu node instead, those are for the VPU power domain.

> reset-names = "viu", "venc", "vcbus", "bt656",
> "rdma", "venci", "vencp", "vdac",
> - "vdi6", "vencl", "vid_lock";
> + "vdi6", "vencl", "vid_lock", "nna";
> clocks = <&clkc CLKID_VPU>,
> <&clkc CLKID_VAPB>;
> clock-names = "vpu", "vapb";