2022-11-28 13:35:08

by Ricardo Neri

Subject: [PATCH v2 04/22] sched/core: Add user_tick as argument to scheduler_tick()

Differentiate between user and kernel ticks so that the scheduler updates
the IPC class of the current task during the latter.

Cc: Ben Segall <[email protected]>
Cc: Daniel Bristot de Oliveira <[email protected]>
Cc: Dietmar Eggemann <[email protected]>
Cc: Joel Fernandes (Google) <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Tim C. Chen <[email protected]>
Cc: Valentin Schneider <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Ricardo Neri <[email protected]>
---
Changes since v1:
* None
---
include/linux/sched.h | 2 +-
kernel/sched/core.c | 2 +-
kernel/time/timer.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 47ae3557ba07..ddabc7449edd 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -293,7 +293,7 @@ enum {
TASK_COMM_LEN = 16,
};

-extern void scheduler_tick(void);
+extern void scheduler_tick(bool user_tick);

#define MAX_SCHEDULE_TIMEOUT LONG_MAX

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 8dd43ee05534..8bb6f597c42b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5487,7 +5487,7 @@ static inline u64 cpu_resched_latency(struct rq *rq) { return 0; }
* This function gets called by the timer code, with HZ frequency.
* We call it with interrupts disabled.
*/
-void scheduler_tick(void)
+void scheduler_tick(bool user_tick)
{
int cpu = smp_processor_id();
struct rq *rq = cpu_rq(cpu);
diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 63a8ce7177dd..e15e24105891 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -2073,7 +2073,7 @@ void update_process_times(int user_tick)
if (in_irq())
irq_work_tick();
#endif
- scheduler_tick();
+ scheduler_tick(user_tick);
if (IS_ENABLED(CONFIG_POSIX_TIMERS))
run_posix_cpu_timers();
}
--
2.25.1

2022-12-07 12:35:15

by Dietmar Eggemann

Subject: Re: [PATCH v2 04/22] sched/core: Add user_tick as argument to scheduler_tick()

On 28/11/2022 14:20, Ricardo Neri wrote:
> Differentiate between user and kernel ticks so that the scheduler updates
> the IPC class of the current task during the latter.

Just to make sure ,,, 05/22 introduces `rq->curr` IPCC update during
user_tick, i.e. the former?

[...]

2022-12-12 18:57:38

by Ricardo Neri

Subject: Re: [PATCH v2 04/22] sched/core: Add user_tick as argument to scheduler_tick()

On Wed, Dec 07, 2022 at 01:21:47PM +0100, Dietmar Eggemann wrote:
> On 28/11/2022 14:20, Ricardo Neri wrote:
> > Differentiate between user and kernel ticks so that the scheduler updates
> > the IPC class of the current task during the latter.
>
> Just to make sure ,,, 05/22 introduces `rq->curr` IPCC update during
> user_tick, i.e. the former?

Yes. Thank you for the catch!