2022-12-01 10:40:34

by Tomeu Vizoso

[permalink] [raw]
Subject: [PATCH v5 1/7] dt-bindings: reset: meson-g12a: Add missing NNA reset

Doesn't appear in the TRM I have, but it is used by the downstream
galcore driver.

Signed-off-by: Tomeu Vizoso <[email protected]>
Acked-by: Neil Armstrong <[email protected]>
---
include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
index 6d487c5eba2c..45f6b8a951d0 100644
--- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
+++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
@@ -69,7 +69,9 @@
#define RESET_PARSER_FETCH 72
#define RESET_CTL 73
#define RESET_PARSER_TOP 74
-/* 75-77 */
+/* 75 */
+#define RESET_NNA 76
+/* 77 */
#define RESET_DVALIN 78
#define RESET_HDMITX 79
/* 80-95 */
--
2.38.1


2022-12-01 13:03:03

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v5 1/7] dt-bindings: reset: meson-g12a: Add missing NNA reset

On 01/12/2022 11:30, Tomeu Vizoso wrote:
> Doesn't appear in the TRM I have, but it is used by the downstream
> galcore driver.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> Acked-by: Neil Armstrong <[email protected]>
> ---
> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> index 6d487c5eba2c..45f6b8a951d0 100644
> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> @@ -69,7 +69,9 @@
> #define RESET_PARSER_FETCH 72
> #define RESET_CTL 73
> #define RESET_PARSER_TOP 74
> -/* 75-77 */
> +/* 75 */
> +#define RESET_NNA 76
> +/* 77 */
> #define RESET_DVALIN 78
> #define RESET_HDMITX 79
> /* 80-95 */

Missing from https://lore.kernel.org/all/[email protected]/ :
Acked-by: Philipp Zabel <[email protected]>

No need to send to send a v6 for that, I'll add it while applying after next rc1.

Neil

2022-12-01 22:40:37

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH v5 1/7] dt-bindings: reset: meson-g12a: Add missing NNA reset

On Thu, Dec 1, 2022 at 11:30 AM Tomeu Vizoso <[email protected]> wrote:
>
> Doesn't appear in the TRM I have, but it is used by the downstream
> galcore driver.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> Acked-by: Neil Armstrong <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>