2022-12-09 08:10:17

by Yang Yang

Subject: [PATCH net-next] net: hns3: use strscpy() to instead of strncpy()

From: Xu Panda <[email protected]>

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Xu Panda <[email protected]>
Signed-off-by: Yang Yang <[email protected]>
---
change for v2
- change the subject, replace linux-next with net-next.
---
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
index cdf76fb58d45..55306fe8a540 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
@@ -639,13 +639,11 @@ static void hns3_get_drvinfo(struct net_device *netdev,
return;
}

- strncpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
+ strscpy(drvinfo->driver, dev_driver_string(&h->pdev->dev),
sizeof(drvinfo->driver));
- drvinfo->driver[sizeof(drvinfo->driver) - 1] = '\0';

- strncpy(drvinfo->bus_info, pci_name(h->pdev),
+ strscpy(drvinfo->bus_info, pci_name(h->pdev),
sizeof(drvinfo->bus_info));
- drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0';

fw_version = priv->ae_handle->ae_algo->ops->get_fw_version(h);

--
2.15.2

2022-12-09 09:35:15

by Jiri Pirko

Subject: Re: [PATCH net-next] net: hns3: use strscpy() to instead of strncpy()

Fri, Dec 09, 2022 at 08:38:59AM CET, [email protected] wrote:
>From: Xu Panda <[email protected]>
>
>The implementation of strscpy() is more robust and safer.
>That's now the recommended way to copy NUL terminated strings.
>
>Signed-off-by: Xu Panda <[email protected]>
>Signed-off-by: Yang Yang <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2022-12-12 21:17:53

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: hns3: use strscpy() to instead of strncpy()

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Jakub Kicinski <[email protected]>:

On Fri, 9 Dec 2022 15:38:59 +0800 (CST) you wrote:
> From: Xu Panda <[email protected]>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <[email protected]>
> Signed-off-by: Yang Yang <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: hns3: use strscpy() to instead of strncpy()
https://git.kernel.org/bpf/bpf-next/c/80a464d83f08

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html