2022-12-17 23:32:44

by Andreas Kemnade

Subject: [PATCH] iio:adc:twl6030: Enable measurement of VAC

VAC needs to be wired up to produce proper measurements,
without this change only near zero values are reported.

Reported-by: kernel test robot <[email protected]>
Reported-by: Julia Lawall <[email protected]>
Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
Signed-off-by: Andreas Kemnade <[email protected]>
---
drivers/iio/adc/twl6030-gpadc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index 40438e5b4970..32873fb5f367 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
}

ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
- VBAT_MEAS | BB_MEAS | BB_MEAS,
+ VBAT_MEAS | BB_MEAS | VAC_MEAS,
TWL6030_MISC1);
if (ret < 0) {
dev_err(dev, "failed to wire up inputs\n");
--
2.30.2

2022-12-23 15:57:57

by Jonathan Cameron

Subject: Re: [PATCH] iio:adc:twl6030: Enable measurement of VAC

On Sat, 17 Dec 2022 23:13:05 +0100
Andreas Kemnade <[email protected]> wrote:

> VAC needs to be wired up to produce proper measurements,
> without this change only near zero values are reported.
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Julia Lawall <[email protected]>
> Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
> Signed-off-by: Andreas Kemnade <[email protected]>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
> drivers/iio/adc/twl6030-gpadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 40438e5b4970..32873fb5f367 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
> }
>
> ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
> - VBAT_MEAS | BB_MEAS | BB_MEAS,
> + VBAT_MEAS | BB_MEAS | VAC_MEAS,
> TWL6030_MISC1);
> if (ret < 0) {
> dev_err(dev, "failed to wire up inputs\n");