2022-12-20 11:18:40

by Bhavya Kapoor

Subject: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
for 8 channel ADCs for J721s2 SoC.

Signed-off-by: Bhavya Kapoor <[email protected]>
---
.../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
.../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
2 files changed, 55 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index a7aa6cf08acd..67593aa69327 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -309,3 +309,17 @@ &mcu_mcan1 {
pinctrl-0 = <&mcu_mcan1_pins_default>;
phys = <&transceiver2>;
};
+
+&tscadc0 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
+
+&tscadc1 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
\ No newline at end of file
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
index 0af242aa9816..ad1bc31619c4 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
@@ -306,4 +306,44 @@ cpts@3d000 {
ti,cpts-periodic-outputs = <2>;
};
};
-};
+
+ tscadc0: tscadc@40200000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40200000 0x0 0x1000>;
+ interrupts = <GIC_SPI 892 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 0 0>;
+ assigned-clocks = <&k3_clks 0 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7400>,
+ <&main_udmap 0x7401>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
+
+ tscadc1: tscadc@40210000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40210000 0x0 0x1000>;
+ interrupts = <GIC_SPI 893 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 1 0>;
+ assigned-clocks = <&k3_clks 1 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7402>,
+ <&main_udmap 0x7403>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
+ };
\ No newline at end of file
--
2.37.2

2022-12-20 11:19:17

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

On 20/12/2022 11:12, Bhavya Kapoor wrote:
> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
> for 8 channel ADCs for J721s2 SoC.
>
> Signed-off-by: Bhavya Kapoor <[email protected]>
> ---
> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
> 2 files changed, 55 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index a7aa6cf08acd..67593aa69327 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -309,3 +309,17 @@ &mcu_mcan1 {
> pinctrl-0 = <&mcu_mcan1_pins_default>;
> phys = <&transceiver2>;
> };
> +
> +&tscadc0 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> +
> +&tscadc1 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> \ No newline at end of file

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof

2022-12-21 06:00:34

by Bhavya Kapoor

Subject: Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

On 20/12/22 16:20, Krzysztof Kozlowski wrote:
> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721s2 SoC.
>>
>> Signed-off-by: Bhavya Kapoor <[email protected]>
>> ---
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index a7aa6cf08acd..67593aa69327 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>> phys = <&transceiver2>;
>> };
>> +
>> +&tscadc0 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> +
>> +&tscadc1 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> \ No newline at end of file
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof

Hi , I thought i did addressed the feedback since tscadc is just a
wrapper node.

The actual adc node is inside of tscadc node.

2022-12-21 08:05:54

by Krzysztof Kozlowski

Subject: Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

On 21/12/2022 06:42, Bhavya Kapoor wrote:
>
> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>> for 8 channel ADCs for J721s2 SoC.
>>>
>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>> ---
>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> index a7aa6cf08acd..67593aa69327 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>> phys = <&transceiver2>;
>>> };
>>> +
>>> +&tscadc0 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> +
>>> +&tscadc1 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> \ No newline at end of file
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>> Best regards,
>> Krzysztof
>
> Hi , I thought i did addressed the feedback since tscadc is just a
> wrapper node.
>
> The actual adc node is inside of tscadc node.

Read the feedback, from all emails.
Best regards,
Krzysztof

2022-12-22 11:11:22

by Bhavya Kapoor

Subject: Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

On 21/12/22 13:24, Krzysztof Kozlowski wrote:
> On 21/12/2022 06:42, Bhavya Kapoor wrote:
>> On 20/12/22 16:20, Krzysztof Kozlowski wrote:
>>> On 20/12/2022 11:12, Bhavya Kapoor wrote:
>>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>>> for 8 channel ADCs for J721s2 SoC.
>>>>
>>>> Signed-off-by: Bhavya Kapoor <[email protected]>
>>>> ---
>>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> index a7aa6cf08acd..67593aa69327 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>>> phys = <&transceiver2>;
>>>> };
>>>> +
>>>> +&tscadc0 {
>>>> + status = "okay";
>>>> + adc {
>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>> + };
>>>> +};
>>>> +
>>>> +&tscadc1 {
>>>> + status = "okay";
>>>> + adc {
>>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>>> + };
>>>> +};
>>>> \ No newline at end of file
>>> This is a friendly reminder during the review process.
>>>
>>> It seems my previous comments were not fully addressed. Maybe my
>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>> Please go back to the previous discussion and either implement all
>>> requested changes or keep discussing them.
>>>
>>> Thank you.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi , I thought i did addressed the feedback since tscadc is just a
>> wrapper node.
>>
>> The actual adc node is inside of tscadc node.
> Read the feedback, from all emails.
> Best regards,
> Krzysztof


Hi , i have gone through all earlier mails but can't find anything else.
Can you point out again whats the issue.

Regards