2022-12-07 19:54:50

by Carl Vanderlip

Subject: [PATCH] mhi: Update Makefile to used Kconfig flags

Makefile was always suggesting to build subdirectories regardless of
Kconfig. Use the Kconfig flags as intended.

Signed-off-by: Carl Vanderlip <[email protected]>
---
drivers/bus/mhi/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
index 46981331b38f..354204b0ef3a 100644
--- a/drivers/bus/mhi/Makefile
+++ b/drivers/bus/mhi/Makefile
@@ -1,5 +1,5 @@
# Host MHI stack
-obj-y += host/
+obj-$(CONFIG_MHI_BUS) += host/

# Endpoint MHI stack
-obj-y += ep/
+obj-$(CONFIG_MHI_BUS_EP) += ep/
--
2.25.1

2022-12-07 20:31:58

by Jeffrey Hugo

Subject: Re: [PATCH] mhi: Update Makefile to used Kconfig flags

On 12/7/2022 12:26 PM, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <[email protected]>

Nice catch.

Reviewed-by: Jeffrey Hugo <[email protected]>

2022-12-28 16:54:33

by Manivannan Sadhasivam

Subject: Re: [PATCH] mhi: Update Makefile to used Kconfig flags

On Wed, Dec 07, 2022 at 11:26:13AM -0800, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/bus/mhi/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
> index 46981331b38f..354204b0ef3a 100644
> --- a/drivers/bus/mhi/Makefile
> +++ b/drivers/bus/mhi/Makefile
> @@ -1,5 +1,5 @@
> # Host MHI stack
> -obj-y += host/
> +obj-$(CONFIG_MHI_BUS) += host/
>
> # Endpoint MHI stack
> -obj-y += ep/
> +obj-$(CONFIG_MHI_BUS_EP) += ep/
> --
> 2.25.1
>

--
மணிவண்ணன் சதாசிவம்

2022-12-28 16:54:37

by Manivannan Sadhasivam

Subject: Re: [PATCH] mhi: Update Makefile to used Kconfig flags

On Wed, Dec 07, 2022 at 11:26:13AM -0800, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <[email protected]>

Applied to mhi-next!

Thanks,
Mani

> ---
> drivers/bus/mhi/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
> index 46981331b38f..354204b0ef3a 100644
> --- a/drivers/bus/mhi/Makefile
> +++ b/drivers/bus/mhi/Makefile
> @@ -1,5 +1,5 @@
> # Host MHI stack
> -obj-y += host/
> +obj-$(CONFIG_MHI_BUS) += host/
>
> # Endpoint MHI stack
> -obj-y += ep/
> +obj-$(CONFIG_MHI_BUS_EP) += ep/
> --
> 2.25.1
>

--
மணிவண்ணன் சதாசிவம்