2022-12-22 18:39:45

by Deepak R Varma

Subject: [PATCH] soc: imx: imx93-pd: No need to set device_driver owner

There is no need to exclusively set the .owner member of the struct
device_driver when defining the platform_driver struct. The Linux core
takes care of setting the .owner member as part of the call to
module_platform_driver() helper function.

Issue identified using the platform_no_drv_owner.cocci Coccinelle
semantic patch.

Signed-off-by: Deepak R Varma <[email protected]>
---
Note: Proposed change compile tested only using ARM64 defconfig.

drivers/soc/imx/imx93-pd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soc/imx/imx93-pd.c b/drivers/soc/imx/imx93-pd.c
index 4d235c8c4924..832deeed8fd6 100644
--- a/drivers/soc/imx/imx93-pd.c
+++ b/drivers/soc/imx/imx93-pd.c
@@ -164,7 +164,6 @@ MODULE_DEVICE_TABLE(of, imx93_pd_ids);
static struct platform_driver imx93_power_domain_driver = {
.driver = {
.name = "imx93_power_domain",
- .owner = THIS_MODULE,
.of_match_table = imx93_pd_ids,
},
.probe = imx93_pd_probe,
--
2.34.1

2023-01-01 05:33:23

by Shawn Guo

Subject: Re: [PATCH] soc: imx: imx93-pd: No need to set device_driver owner

On Thu, Dec 22, 2022 at 11:23:16PM +0530, Deepak R Varma wrote:
> There is no need to exclusively set the .owner member of the struct
> device_driver when defining the platform_driver struct. The Linux core
> takes care of setting the .owner member as part of the call to
> module_platform_driver() helper function.
>
> Issue identified using the platform_no_drv_owner.cocci Coccinelle
> semantic patch.
>
> Signed-off-by: Deepak R Varma <[email protected]>

Applied, thanks!