in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()
Signed-off-by: 李哲 <[email protected]>
V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/
---
drivers/tty/serial/fsl_linflexuart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
return PTR_ERR(sport->membase);
sport->dev = &pdev->dev;
- sport->type = PORT_LINFLEXUART;
sport->iotype = UPIO_MEM;
sport->irq = platform_get_irq(pdev, 0);
sport->ops = &linflex_pops;
--
2.17.1
On 05. 01. 23, 18:04, 李哲 wrote:
> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
I wrote to v5:
Please use capitals when you start a sentence. And periods at the ends
of them.
> Signed-off-by: 李哲 <[email protected]>
> V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
> V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
> V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
> V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/
This is not the proper way. PLease see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
> ---
> drivers/tty/serial/fsl_linflexuart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
> return PTR_ERR(sport->membase);
>
> sport->dev = &pdev->dev;
> - sport->type = PORT_LINFLEXUART;
> sport->iotype = UPIO_MEM;
> sport->irq = platform_get_irq(pdev, 0);
> sport->ops = &linflex_pops;
--
js
suse labs
On Thu, Jan 05, 2023 at 09:04:37AM -0800, 李哲 wrote:
> in linflex_config_port() the member variable type will be
> assigned again. see linflex_connfig_port()
>
> Signed-off-by: 李哲 <[email protected]>
> V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
> V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
> V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
> V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/
Links are not ok for versioning, sorry, please read the documentation
for how to do this properly.
greg k-h
On Fri, 5 Jan 2024, lizhe wrote:
> HI，all
>
> How should I wirte these comments ? please help me,
> i am not sure how to properly write these comments,
> i want to merge this patch into the mainline
>
>
>
>
>
>
> At 2023-01-06 15:16:56, "Jiri Slaby" <[email protected]> wrote:
> >On 05. 01. 23, 18:04, 李哲 wrote:
> >> in linflex_config_port() the member variable type will be
> >> assigned again. see linflex_connfig_port()
> >
> >I wrote to v5:
> >Please use capitals when you start a sentence. And periods at the ends
> >of them.
> >> Signed-off-by: 李哲 <[email protected]>
> >
> >
> >> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d
> [email protected]/
> >> V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f
> [email protected]/
> >> V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc
> [email protected]/
> >> V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41
> [email protected]/
> >
> >This is not the proper way. PLease see:
> >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-
> canonical-patch-format
For this you need to spell out the changes you made between versions.
E.g.,
v6:
- Used Chinese letters for From and Signed-off-by
--
i.