2023-01-11 05:39:16

by Noor Azura Ahmad Tarmizi

Subject: [PATCH net v2 1/1] net: stmmac: add aux timestamps fifo clearance wait

Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
(ATSFC) to clear. This is to ensure no residue fifo value is being read
erroneously.

Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
Cc: <[email protected]> # 5.10.x
Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index fc06ddeac0d5..b4388ca8d211 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -210,7 +210,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
}
writel(acr_value, ptpaddr + PTP_ACR);
mutex_unlock(&priv->aux_ts_lock);
- ret = 0;
+ /* wait for auxts fifo clear to finish */
+ ret = readl_poll_timeout(ptpaddr + PTP_ACR, acr_value,
+ !(acr_value & PTP_ACR_ATSFC),
+ 10, 10000);
break;

default:
--
2.17.1

2023-01-12 06:42:33

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net v2 1/1] net: stmmac: add aux timestamps fifo clearance wait

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 11 Jan 2023 13:02:00 +0800 you wrote:
> Add timeout polling wait for auxiliary timestamps snapshot FIFO clear bit
> (ATSFC) to clear. This is to ensure no residue fifo value is being read
> erroneously.
>
> Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
> Cc: <[email protected]> # 5.10.x
> Signed-off-by: Noor Azura Ahmad Tarmizi <[email protected]>
>
> [...]

Here is the summary with links:
- [net,v2,1/1] net: stmmac: add aux timestamps fifo clearance wait
https://git.kernel.org/netdev/net/c/ae9dcb91c606

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html