2023-01-11 21:02:02

by Andreas Kemnade

Subject: [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks

Currently make dtbs_check shows lots of errors because imx*.dtsi does
not use single compatibles but combinations of them.

Add fallbacks for imx6sll/ull which are useful for U-Boot.

This will significantly reduce noise on make dtbs_check.

Signed-off-by: Andreas Kemnade <[email protected]>
---
Changes in v2:
- allow only combinations with fallback compatible
- reduce them to the cases where they are actually useful

Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index dc6256f04b42..be6caa25c57d 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -29,14 +29,18 @@ properties:
- fsl,imx53-esdhc
- fsl,imx6q-usdhc
- fsl,imx6sl-usdhc
- - fsl,imx6sll-usdhc
- fsl,imx6sx-usdhc
- - fsl,imx6ull-usdhc
- fsl,imx7d-usdhc
- fsl,imx7ulp-usdhc
- fsl,imx8mm-usdhc
- fsl,imxrt1050-usdhc
- nxp,s32g2-usdhc
+ - items:
+ - const: fsl,imx6sll-usdhc
+ - const: fsl,imx6sx-usdhc
+ - items:
+ - const: fsl,imx6ull-usdhc
+ - const: fsl,imx6sx-usdhc
- items:
- enum:
- fsl,imx8mq-usdhc
--
2.30.2

2023-01-13 19:32:48

by Rob Herring (Arm)

Subject: Re: [PATCH v2] dt-bindings: mmc: fsl-imx-esdhc: Add some compatible fallbacks

On Wed, Jan 11, 2023 at 09:46:33PM +0100, Andreas Kemnade wrote:
> Currently make dtbs_check shows lots of errors because imx*.dtsi does
> not use single compatibles but combinations of them.
>
> Add fallbacks for imx6sll/ull which are useful for U-Boot.
>
> This will significantly reduce noise on make dtbs_check.
>
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> Changes in v2:
> - allow only combinations with fallback compatible
> - reduce them to the cases where they are actually useful
>
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index dc6256f04b42..be6caa25c57d 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -29,14 +29,18 @@ properties:
> - fsl,imx53-esdhc
> - fsl,imx6q-usdhc
> - fsl,imx6sl-usdhc
> - - fsl,imx6sll-usdhc
> - fsl,imx6sx-usdhc
> - - fsl,imx6ull-usdhc
> - fsl,imx7d-usdhc
> - fsl,imx7ulp-usdhc
> - fsl,imx8mm-usdhc
> - fsl,imxrt1050-usdhc
> - nxp,s32g2-usdhc
> + - items:
> + - const: fsl,imx6sll-usdhc
> + - const: fsl,imx6sx-usdhc
> + - items:
> + - const: fsl,imx6ull-usdhc
> + - const: fsl,imx6sx-usdhc

Can be simplified to:

- items:
- enum:
- fsl,imx6sll-usdhc
- fsl,imx6ull-usdhc
- const: fsl,imx6sx-usdhc