2023-01-20 17:47:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso

The Panfrost GPU drivers require clock but such was not provided in
Exynos7 DTSI. The CMU_G3D clock controller was not upstreamed, thus
consider GPU as non-working and simply disable it to silence warnings
like:

exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

This patchset fixes remaining Exynos/Tesla ARMv8 dtbs_check warnings. No
more excuses for not running dtbs_check on new patches.
---
arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index b846c0be90e3..829657c9c7ca 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -61,7 +61,6 @@ &fin_pll {

&gpu {
mali-supply = <&buck6_reg>;
- status = "okay";
};

&serial_2 {
--
2.34.1


2023-01-20 18:07:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 5/6] arm64: dts: exynos: add interrupt-controller to WM5110 on TM2

The WM5110 bindings expect node to be interrupt controller:

exynos5433-tm2.dtb: audio-codec@0: 'interrupt-controller' is a required property
exynos5433-tm2.dtb: audio-codec@0: '#interrupt-cells' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 3785a6580bdf..5124027d7541 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -1285,6 +1285,8 @@ wm5110: audio-codec@0 {

gpio-controller;
#gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;

wlf,micd-detect-debounce = <300>;
wlf,micd-bias-start-time = <0x1>;
--
2.34.1

2023-01-23 10:01:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso

On Fri, 20 Jan 2023 18:31:11 +0100, Krzysztof Kozlowski wrote:
> The Panfrost GPU drivers require clock but such was not provided in
> Exynos7 DTSI. The CMU_G3D clock controller was not upstreamed, thus
> consider GPU as non-working and simply disable it to silence warnings
> like:
>
> exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property
>
> [...]

Applied, thanks!

[1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso
https://git.kernel.org/krzk/linux/c/e251bbd6faca7f0ee1986a8534ceab9042e0e73a
[2/6] arm64: dts: exynos: add ADC supply on Exynos7 Espresso
https://git.kernel.org/krzk/linux/c/4fffea1941bf527f55f6ac98584672206b26781f
[3/6] arm64: dts: exynos: correct Bluetooth LED triger on E850-96
https://git.kernel.org/krzk/linux/c/706528771a73ad9963e257ede00a09960720fa12
[4/6] arm64: dts: exynos: add VPH_PWR regulator on TM2
https://git.kernel.org/krzk/linux/c/d65703ba28f3afc3a530d1f70f437e226733d776
[5/6] arm64: dts: exynos: add interrupt-controller to WM5110 on TM2
https://git.kernel.org/krzk/linux/c/73cdaf6c6bbec3e8b506b501863457c9d01b964d
[6/6] arm64: dts: exynos: correct wlf,micd-dbtime on TM2
https://git.kernel.org/krzk/linux/c/662009c7f4aac7bb415e75e197ff6cd83863d5ab

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2023-01-28 06:49:19

by Alim Akhtar

[permalink] [raw]
Subject: RE: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on Exynos7 Espresso



> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Friday, January 20, 2023 11:01 PM
> To: Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: Sam Protsenko <[email protected]>; Chanho Park
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>
> Subject: [PATCH 1/6] arm64: dts: exynos: disable non-working GPU on
> Exynos7 Espresso
>
> The Panfrost GPU drivers require clock but such was not provided in
> Exynos7 DTSI. The CMU_G3D clock controller was not upstreamed, thus
> consider GPU as non-working and simply disable it to silence warnings
> like:
>
> exynos7-espresso.dtb: gpu@14ac0000: 'clocks' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---

Reviewed-by: Alim Akhtar <[email protected]>

>
> This patchset fixes remaining Exynos/Tesla ARMv8 dtbs_check warnings. No
> more excuses for not running dtbs_check on new patches.

Thanks Krzysztof for cleaning it up.

> ---
> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index b846c0be90e3..829657c9c7ca 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -61,7 +61,6 @@ &fin_pll {
>
> &gpu {
> mali-supply = <&buck6_reg>;
> - status = "okay";
> };
>
> &serial_2 {
> --
> 2.34.1