2023-02-14 06:41:28

by Jiangshan Yi

Subject: [PATCH] md/raid10: Fix typo in comment (replacment -> replacement)

Replace replacment with replacement.

Signed-off-by: Jiangshan Yi <[email protected]>
---
drivers/md/raid10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 6c66357f92f5..7b264add0d52 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1626,7 +1626,7 @@ static void raid10_end_discard_request(struct bio *bio)
/*
* raid10_remove_disk uses smp_mb to make sure rdev is set to
* replacement before setting replacement to NULL. It can read
- * rdev first without barrier protect even replacment is NULL
+ * rdev first without barrier protect even replacement is NULL
*/
smp_rmb();
rdev = conf->mirrors[dev].rdev;
--
2.27.0

2023-03-13 21:33:19

by Song Liu

Subject: Re: [PATCH] md/raid10: Fix typo in comment (replacment -> replacement)

On Mon, Feb 13, 2023 at 10:41 PM Jiangshan Yi <[email protected]> wrote:
>
> Replace replacment with replacement.
>
> Signed-off-by: Jiangshan Yi <[email protected]>

To be honest, I see very little value from typo fixes in comments.

I will apply this one, but I may start rejecting them in the future.

Thanks,
Song

> ---
> drivers/md/raid10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 6c66357f92f5..7b264add0d52 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1626,7 +1626,7 @@ static void raid10_end_discard_request(struct bio *bio)
> /*
> * raid10_remove_disk uses smp_mb to make sure rdev is set to
> * replacement before setting replacement to NULL. It can read
> - * rdev first without barrier protect even replacment is NULL
> + * rdev first without barrier protect even replacement is NULL
> */
> smp_rmb();
> rdev = conf->mirrors[dev].rdev;
> --
> 2.27.0
>