2023-02-26 05:40:15

by Randy Dunlap

Subject: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it

REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP" to "select REGMAP".

Fixes: ef0f62264b2a ("platform/x86: mlx-platform: Add physical bus number auto detection")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Vadim Pasternak <[email protected]>
Cc: Darren Hart <[email protected]>
Cc: Hans de Goede <[email protected]>
Cc: Mark Gross <[email protected]>
Cc: [email protected]
---
drivers/platform/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff -- a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -955,7 +955,8 @@ config SERIAL_MULTI_INSTANTIATE

config MLX_PLATFORM
tristate "Mellanox Technologies platform support"
- depends on I2C && REGMAP
+ depends on I2C
+ select REGMAP
help
This option enables system support for the Mellanox Technologies
platform. The Mellanox systems provide data center networking

2023-02-26 06:37:52

by Vadim Pasternak

Subject: RE: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it

> -----Original Message-----
> From: Randy Dunlap <[email protected]>
> Sent: Sunday, 26 February 2023 7:40
> To: [email protected]
> Cc: Randy Dunlap <[email protected]>; Vadim Pasternak
> <[email protected]>; Darren Hart <[email protected]>; Hans de
> Goede <[email protected]>; Mark Gross <[email protected]>;
> [email protected]
> Subject: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead
> of depending on it
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru
> "make *config", so drivers should select it instead of depending on it if they
> need it.
>
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ef0f62264b2a ("platform/x86: mlx-platform: Add physical bus number
> auto detection")
> Signed-off-by: Randy Dunlap <[email protected]>

Acked-by: Vadim Pasternak <[email protected]>

> Cc: Vadim Pasternak <[email protected]>
> Cc: Darren Hart <[email protected]>
> Cc: Hans de Goede <[email protected]>
> Cc: Mark Gross <[email protected]>
> Cc: [email protected]
> ---
> drivers/platform/x86/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -955,7 +955,8 @@ config SERIAL_MULTI_INSTANTIATE
>
> config MLX_PLATFORM
> tristate "Mellanox Technologies platform support"
> - depends on I2C && REGMAP
> + depends on I2C
> + select REGMAP
> help
> This option enables system support for the Mellanox Technologies
> platform. The Mellanox systems provide data center networking