2023-02-27 21:00:51

by André Apitzsch

Subject: [PATCH 1/2] dt-bindings: input: atmel,maxtouch: add linux,keycodes

In some configurations the touch controller can support the touch keys.
Document the linux,keycodes property that enables those keys and
specifies the keycodes that should be used to report the key events.

Signed-off-by: André Apitzsch <[email protected]>
---
.../devicetree/bindings/input/atmel,maxtouch.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
index 3ec579d63570..c40799355ed7 100644
--- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
+++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
@@ -14,6 +14,9 @@ description: |
Atmel maXTouch touchscreen or touchpads such as the mXT244
and similar devices.

+allOf:
+ - $ref: input.yaml#
+
properties:
compatible:
const: atmel,maxtouch
@@ -60,6 +63,10 @@ properties:
or experiment to determine which bit corresponds to which input. Use
KEY_RESERVED for unused padding values.

+ linux,keycodes:
+ minItems: 1
+ maxItems: 8
+
atmel,wakeup-method:
$ref: /schemas/types.yaml#/definitions/uint32
description: |

base-commit: 982818426a0ffaf93b0621826ed39a84be3d7d62
--
2.39.2

2023-02-28 08:18:53

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: input: atmel,maxtouch: add linux,keycodes

On 27/02/2023 21:50, André Apitzsch wrote:
> In some configurations the touch controller can support the touch keys.
> Document the linux,keycodes property that enables those keys and
> specifies the keycodes that should be used to report the key events.
>
> Signed-off-by: André Apitzsch <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-03-06 14:22:50

by Linus Walleij

Subject: Re: [PATCH 1/2] dt-bindings: input: atmel,maxtouch: add linux,keycodes

On Mon, Feb 27, 2023 at 9:50 PM André Apitzsch <[email protected]> wrote:

> In some configurations the touch controller can support the touch keys.
> Document the linux,keycodes property that enables those keys and
> specifies the keycodes that should be used to report the key events.
>
> Signed-off-by: André Apitzsch <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-03-25 11:05:58

by André Apitzsch

Subject: Re: [PATCH 1/2] dt-bindings: input: atmel,maxtouch: add linux,keycodes

Am Montag, dem 27.02.2023 um 21:50 +0100 schrieb André Apitzsch:
> In some configurations the touch controller can support the touch keys.
> Document the linux,keycodes property that enables those keys and
> specifies the keycodes that should be used to report the key events.
>
> Signed-off-by: André Apitzsch <[email protected]>
> ---
> .../devicetree/bindings/input/atmel,maxtouch.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> index 3ec579d63570..c40799355ed7 100644
> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> @@ -14,6 +14,9 @@ description: |
> Atmel maXTouch touchscreen or touchpads such as the mXT244
> and similar devices.
>
> +allOf:
> + - $ref: input.yaml#
> +
> properties:
> compatible:
> const: atmel,maxtouch
> @@ -60,6 +63,10 @@ properties:
> or experiment to determine which bit corresponds to which input. Use
> KEY_RESERVED for unused padding values.
>
> + linux,keycodes:
> + minItems: 1
> + maxItems: 8
> +
> atmel,wakeup-method:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: |
>
> base-commit: 982818426a0ffaf93b0621826ed39a84be3d7d62

Hi Nick, hi Dmitry,

Friendly ping.

What is missing to get this up-streamed?

Best regards,
André