2023-03-09 05:33:57

by Gao Xiang

Subject: [PATCH 2/2] erofs: get rid of an useless DBG_BUGON

`err` could be -EINTR and it should not be the case. Actually such
DBG_BUGON is useless.

Signed-off-by: Gao Xiang <[email protected]>
---
fs/erofs/zmap.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c
index 8bf6d30518b6..655da4d739cb 100644
--- a/fs/erofs/zmap.c
+++ b/fs/erofs/zmap.c
@@ -757,9 +757,6 @@ int z_erofs_map_blocks_iter(struct inode *inode, struct erofs_map_blocks *map,
err = z_erofs_do_map_blocks(inode, map, flags);
out:
trace_z_erofs_map_blocks_iter_exit(inode, map, flags, err);
-
- /* aggressively BUG_ON iff CONFIG_EROFS_FS_DEBUG is on */
- DBG_BUGON(err < 0 && err != -ENOMEM);
return err;
}

--
2.24.4

2023-03-09 14:34:49

by Chao Yu

Subject: Re: [PATCH 2/2] erofs: get rid of an useless DBG_BUGON

On 2023/3/9 13:31, Gao Xiang wrote:
> `err` could be -EINTR and it should not be the case. Actually such
> DBG_BUGON is useless.
>
> Signed-off-by: Gao Xiang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,