2023-03-21 11:47:38

by Wolfram Sang

[permalink] [raw]
Subject: [PATCH net-next] smsc911x: remove superfluous variable init

phydev is assigned a value right away, no need to initialize it.

Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/net/ethernet/smsc/smsc911x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 25e867b74185..037a2b6b89d7 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1016,7 +1016,7 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
static int smsc911x_mii_probe(struct net_device *dev)
{
struct smsc911x_data *pdata = netdev_priv(dev);
- struct phy_device *phydev = NULL;
+ struct phy_device *phydev;
int ret;

phydev = phy_find_first(pdata->mii_bus);
--
2.30.2



2023-03-21 14:28:19

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init

Hi Wolfram,

On Tue, Mar 21, 2023 at 12:50 PM Wolfram Sang
<[email protected]> wrote:
> phydev is assigned a value right away, no need to initialize it.
>
> Signed-off-by: Wolfram Sang <[email protected]>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/drivers/net/ethernet/smsc/smsc911x.c
> +++ b/drivers/net/ethernet/smsc/smsc911x.c
> @@ -1016,7 +1016,7 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
> static int smsc911x_mii_probe(struct net_device *dev)
> {
> struct smsc911x_data *pdata = netdev_priv(dev);
> - struct phy_device *phydev = NULL;
> + struct phy_device *phydev;
> int ret;
>
> phydev = phy_find_first(pdata->mii_bus);

Nit: perhaps combine this assignment with the variable declaration?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-03-21 14:38:43

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init


> > struct smsc911x_data *pdata = netdev_priv(dev);
> > - struct phy_device *phydev = NULL;
> > + struct phy_device *phydev;
> > int ret;
> >
> > phydev = phy_find_first(pdata->mii_bus);
>
> Nit: perhaps combine this assignment with the variable declaration?

I thought about it but found this version to be easier readable.

Thanks!

Attachments:
(No filename) (373.00 B)
 signature.asc (833.00 B)
 Download all attachments

2023-03-21 19:27:55

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init

On Tue, 21 Mar 2023 15:38:31 +0100 Wolfram Sang wrote:
> > > struct smsc911x_data *pdata = netdev_priv(dev);
> > > - struct phy_device *phydev = NULL;
> > > + struct phy_device *phydev;
> > > int ret;
> > >
> > > phydev = phy_find_first(pdata->mii_bus);
> >
> > Nit: perhaps combine this assignment with the variable declaration?
>
> I thought about it but found this version to be easier readable.

+1

Calling functions which need their return value error-checked as part
of the variable declaration should be against the kernel coding style
IMHO.

2023-03-22 15:10:11

by Paolo Abeni

[permalink] [raw]
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init

On Tue, 2023-03-21 at 15:38 +0100, Wolfram Sang wrote:
> > >         struct smsc911x_data *pdata = netdev_priv(dev);
> > > - struct phy_device *phydev = NULL;
> > > + struct phy_device *phydev;
> > >         int ret;
> > >
> > >         phydev = phy_find_first(pdata->mii_bus);
> >
> > Nit: perhaps combine this assignment with the variable declaration?
>
> I thought about it but found this version to be easier readable.

This patch does not apply cleanly to net-next, please rebase and
resping.

Thanks!

Paolo