2023-03-24 16:28:13

by Jeffrey Hugo

Subject: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check

If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
is a better error code since it implies an out of range condition.

Suggested-by: Manivannan Sadhasivam <[email protected]>
Signed-off-by: Jeffrey Hugo <[email protected]>
---

This feels more like a style change than fixing a bug, so I'm being
conservative and intentionally not listing a fixes tag.

drivers/bus/mhi/host/init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
index b46a082..f72fcb6 100644
--- a/drivers/bus/mhi/host/init.c
+++ b/drivers/bus/mhi/host/init.c
@@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
if (bhi_off >= mhi_cntrl->reg_len) {
dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
bhi_off, mhi_cntrl->reg_len);
- ret = -EINVAL;
+ ret = -ERANGE;
goto error_reg_offset;
}
mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
@@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
dev_err(dev,
"BHIe offset: 0x%x is out of range: 0x%zx\n",
bhie_off, mhi_cntrl->reg_len);
- ret = -EINVAL;
+ ret = -ERANGE;
goto error_reg_offset;
}
mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
--
2.7.4

2023-03-27 10:26:44

by Manivannan Sadhasivam

Subject: Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check

On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <[email protected]>
> Signed-off-by: Jeffrey Hugo <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>
>

--
மணிவண்ணன் சதாசிவம்

2023-04-03 05:19:35

by Manivannan Sadhasivam

Subject: Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check

On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <[email protected]>
> Signed-off-by: Jeffrey Hugo <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

- Mani

> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்

2023-04-03 05:20:47

by Manivannan Sadhasivam

Subject: Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check

On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <[email protected]>
> Signed-off-by: Jeffrey Hugo <[email protected]>

Applied to mhi-next!

- Mani

> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்